Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to display different color on a port led with different speed? #1573

Open
appleCh opened this issue Apr 9, 2018 · 2 comments
Open

How to display different color on a port led with different speed? #1573

appleCh opened this issue Apr 9, 2018 · 2 comments
Assignees

Comments

@appleCh
Copy link

appleCh commented Apr 9, 2018

According to https://github.com/Azure/SONiC/wiki/Port-Breakout-High-Level-Design,
A 100G port can be breakout to four 25G ports.
If we want to use two color to recognize port speed,
such as port up at 100G with white coler, non-100G with green color,
Have any porting guide to reference?

As far as we know that init port led is by "rcload ${PLATFORM_DIR}/led_proc_init.soc "
(https://github.com/Azure/sonic-buildimage/blob/master/platform/broadcom/docker-syncd-brcm/start.sh),
it use "led auto on" command to register led linkscan callback.
The cb seems only trun on 0x01 present LINKUP, we can not know the port up with what speed.

@serhepopovych
Copy link
Contributor

One of the possible approach for doing this is turn off "led auto off" for all LED processors in your switch and write led_control.py service for your switch as described here: https://github.com/Azure/SONiC/wiki/Porting-Guide and control LED colors manually.

In most cases you may control LEDs using bcmcmd "setreg <led_microprocessor_register> " .
Register is specific to your platform/device.

As side effect you will loose ability to control LED blinking if that supported by led_proc_init.soc.

@lguohan
Copy link
Collaborator

lguohan commented Aug 24, 2018

there is a bigger question of whether sonic should have a standardized front panel port led scheme depending the coloring supported by each platform. we need to have a community discussion first on that.

lguohan added a commit to lguohan/sonic-buildimage that referenced this issue Jan 29, 2021
* 832815e 2021-01-28 | [orchagent]: Add MACsec Orchagent (sonic-net#1474) (HEAD, origin/master, origin/HEAD) [Ze Gan]
* dd4e409 2021-01-28 | [MACsecMgr]: Add MACsec Manager (sonic-net#1475) [Ze Gan]
* 91e231c 2021-01-28 | [portsorch] Configure hostif tagging for subports (sonic-net#1573) [Vitaliy Senchyshyn]
* 008325c 2021-01-29 | [PortsOrch] Add reference counting to ports for ACL bindings (sonic-net#1614) [chaoskao]
* bbd2ca6 2021-01-28 | [crm]: Ignore unsupported/non-implemented switch attributes (sonic-net#1613) [Prabhu Sreenivasan]

Signed-off-by: Guohan Lu <lguohan@gmail.com>
lguohan added a commit that referenced this issue Jan 29, 2021
* 832815e 2021-01-28 | [orchagent]: Add MACsec Orchagent (#1474) (HEAD, origin/master, origin/HEAD) [Ze Gan]
* dd4e409 2021-01-28 | [MACsecMgr]: Add MACsec Manager (#1475) [Ze Gan]
* 91e231c 2021-01-28 | [portsorch] Configure hostif tagging for subports (#1573) [Vitaliy Senchyshyn]
* 008325c 2021-01-29 | [PortsOrch] Add reference counting to ports for ACL bindings (#1614) [chaoskao]
* bbd2ca6 2021-01-28 | [crm]: Ignore unsupported/non-implemented switch attributes (#1613) [Prabhu Sreenivasan]

Signed-off-by: Guohan Lu <lguohan@gmail.com>
deran1980 pushed a commit to deran1980/sonic-buildimage that referenced this issue Feb 4, 2021
* 832815e 2021-01-28 | [orchagent]: Add MACsec Orchagent (sonic-net#1474) (HEAD, origin/master, origin/HEAD) [Ze Gan]
* dd4e409 2021-01-28 | [MACsecMgr]: Add MACsec Manager (sonic-net#1475) [Ze Gan]
* 91e231c 2021-01-28 | [portsorch] Configure hostif tagging for subports (sonic-net#1573) [Vitaliy Senchyshyn]
* 008325c 2021-01-29 | [PortsOrch] Add reference counting to ports for ACL bindings (sonic-net#1614) [chaoskao]
* bbd2ca6 2021-01-28 | [crm]: Ignore unsupported/non-implemented switch attributes (sonic-net#1613) [Prabhu Sreenivasan]

Signed-off-by: Guohan Lu <lguohan@gmail.com>
stephenxs added a commit to stephenxs/sonic-buildimage that referenced this issue Apr 23, 2021
adf5ab58 [vstest/subintf] Add vs test case to validate processing sequence of APPL DB keys (sonic-net#1663)
8a732726 [intfsorch] Create subport with the entry contains necessary attributes (sonic-net#1650)
7ba813b2 [vstest/subintf] Update vs tests to validate physical port host interface vlan tag attribute (sonic-net#1634)
ed32e333 [portsorch] Configure hostif tagging for subports (sonic-net#1573)
b5209c43 Handle IPv6 and ECMP routes to be programmed to ASIC (sonic-net#1711)
515cc1a7 [Dynamic buffer calc][Mellanox] Fix bug: buffer over subscription in buffer pool size calculation (sonic-net#1706)
0ad524b2 [202012] Allowing the first time FEC and AN configuration to be pushed to SAI (sonic-net#1710)

Signed-off-by: Stephen Sun <stephens@nvidia.com>
lguohan pushed a commit that referenced this issue Apr 24, 2021
adf5ab58 [vstest/subintf] Add vs test case to validate processing sequence of APPL DB keys (#1663)
8a732726 [intfsorch] Create subport with the entry contains necessary attributes (#1650)
7ba813b2 [vstest/subintf] Update vs tests to validate physical port host interface vlan tag attribute (#1634)
ed32e333 [portsorch] Configure hostif tagging for subports (#1573)
b5209c43 Handle IPv6 and ECMP routes to be programmed to ASIC (#1711)
515cc1a7 [Dynamic buffer calc][Mellanox] Fix bug: buffer over subscription in buffer pool size calculation (#1706)
0ad524b2 [202012] Allowing the first time FEC and AN configuration to be pushed to SAI (#1710)

Signed-off-by: Stephen Sun <stephens@nvidia.com>
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this issue Feb 5, 2022
Configure SAI_HOSTIF_VLAN_TAG_KEEP for the parent port hostif when a first subport is added and restore it to SAI_HOSTIF_VLAN_TAG_STRIP when the last subport is removed.

Signed-off-by: Vitaliy Senchyshyn <vsenchyshyn@barefootnetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants