Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tacacs] NSS plugin should support user without secondary_grp #1627

Open
taoyl-ms opened this issue Apr 20, 2018 · 0 comments
Open

[tacacs] NSS plugin should support user without secondary_grp #1627

taoyl-ms opened this issue Apr 20, 2018 · 0 comments
Assignees

Comments

@taoyl-ms
Copy link
Contributor

Description

Current user adding logic in TACACS NSS module checks if user->secondary_grp exists and only when it has none-NULL value calls the following command to create user:

snprintf(buf, len, "useradd -G %s \"%s\" -g %d -c \"%s\" -d /home/%s -m -s %s",
    user->secondary_grp, name, user->gid, user->info, name, user->shell);

Because of this, currently in order to create a user belonging to only one group, we'll need to specify group id in user->gid and group name in user->secondary_grp again.

Should support cases that user->secondary_grp is empty and create user account without using -G correspondingly.

@taoyl-ms taoyl-ms changed the title TACACS NSS plugin should support user without secondary_grp [tacacs] NSS plugin should support user without secondary_grp Apr 20, 2018
abdosi added a commit that referenced this issue May 31, 2021
5f62262e5f9b5a18d94764b7f0883b34f094a0c3 (HEAD -> 201911, origin/201911) Fix unicode issue in ipaddress for python2 (#1627)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this issue Feb 5, 2022
1. Fix bug about the return value of `get_value`, it should return `true` if it's OK
2. Fix bug about the type of `MACsecProfile::priority`, the original `uint8_t` will cause a `lexical_convert` failure when the priority is a integer.
3. Polish log in `get_value`.
4. Change the predefined paths for sonic-buildimage integration

Signed-off-by: Ze Gan <ganze718@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants