Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fsck-root script does not run fsck to check FS #16938

Closed
stepanblyschak opened this issue Oct 18, 2023 · 0 comments · Fixed by #17424
Closed

fsck-root script does not run fsck to check FS #16938

stepanblyschak opened this issue Oct 18, 2023 · 0 comments · Fixed by #17424
Assignees
Labels
NVIDIA Triaged this issue has been triaged

Comments

@stepanblyschak
Copy link
Collaborator

stepanblyschak commented Oct 18, 2023

Description

SONiC has a script fsck-root that runs at boot at initramfs stage. It should run fsck to perform FS check and the result of execution is shown later to the syslog.

Steps to reproduce the issue:

  1. Boot into SONiC initramfs
  2. Run sh -x /scripts/init-premount/fsck-rootfs

Describe the results you received:

(initramfs) sh -x /scripts/init-premount/fsck-rootfs
+ root_val=
+ cat /proc/cmdline
+ set -- 'BOOT_IMAGE=/image-202305_RC.8-8bd96c572_Internal/boot/vmlinuz-5.10.0-18-2-amd64' 'root=UUID=1d32e99c-d71f-418e-95ab-4804cbe622b8' rw 'console=tty0' 'console=ttyS0,9600n8' quiet 'processor.max_cstate=1' 'intel_idle.max_cstate=0' 'net.ifnames=0' 'biosdevname=0' 'loop=image-202305_RC.8-8bd96c572_Internal/fs.squashfs' 'loopfstype=squashfs' 'systemd.unified_cgroup_hierarchy=0' 'apparmor=1' 'security=apparmor' 'varlog_size=4096' 'usbcore.autosuspend=-1' break
+ root_val='UUID=1d32e99c-d71f-418e-95ab-4804cbe622b8'
+ '[' '!' -z 'UUID=1d32e99c-d71f-418e-95ab-4804cbe622b8' ]
+ blkid -o value -s TYPE 'UUID=1d32e99c-d71f-418e-95ab-4804cbe622b8'
+ fstype=
+ '[' '!' -z  ]

Describe the results you expected:

FS check executed and reported in syslog.

Output of show version:

SONiC Software Version: SONiC.202305_RC.8-8bd96c572_Internal
SONiC OS Version: 11
Distribution: Debian 11.8
Kernel: 5.10.0-18-2-amd64
Build commit: 276eaeec4
Build date: Tue Oct 10 19:06:35 UTC 2023
Built by: sw-r2d2-bot@r-build-sonic-ci03-244

Platform: x86_64-mlnx_msn4410-r0
HwSKU: ACS-MSN4410
ASIC: mellanox
ASIC Count: 1
Serial Number: Undefined.
Model Number: Undefined.
Hardware Revision: N/A
Uptime: 18:29:54 up 3 min,  1 user,  load average: 1.69, 0.52, 0.18
Date: Wed 18 Oct 2023 18:29:54

Docker images:
REPOSITORY                                         TAG                              IMAGE ID       SIZE
docker-orchagent                                   202305_RC.8-8bd96c572_Internal   160a62bcbba2   343MB
docker-orchagent                                   latest                           160a62bcbba2   343MB
docker-fpm-frr                                     202305_RC.8-8bd96c572_Internal   a8f989f0eba1   362MB
docker-fpm-frr                                     latest                           a8f989f0eba1   362MB
docker-nat                                         202305_RC.8-8bd96c572_Internal   f751e3e0b2c5   334MB
docker-nat                                         latest                           f751e3e0b2c5   334MB
docker-sflow                                       202305_RC.8-8bd96c572_Internal   52fe339aae94   332MB
docker-sflow                                       latest                           52fe339aae94   332MB
docker-teamd                                       202305_RC.8-8bd96c572_Internal   27f31d5f910e   331MB
docker-teamd                                       latest                           27f31d5f910e   331MB
docker-macsec                                      latest                           d3425ce8dffc   333MB
docker-syncd-mlnx                                  202305_RC.8-8bd96c572_Internal   3e67efe75ef7   850MB
docker-syncd-mlnx                                  latest                           3e67efe75ef7   850MB
docker-platform-monitor                            202305_RC.8-8bd96c572_Internal   65bab5d374c3   841MB
docker-platform-monitor                            latest                           65bab5d374c3   841MB
docker-snmp                                        202305_RC.8-8bd96c572_Internal   7a23b7d31c1d   352MB
docker-snmp                                        latest                           7a23b7d31c1d   352MB
docker-dhcp-relay                                  latest                           c9a2b9f352c5   321MB
docker-sonic-telemetry                             202305_RC.8-8bd96c572_Internal   ae6f004b8e58   400MB
docker-sonic-telemetry                             latest                           ae6f004b8e58   400MB
docker-eventd                                      202305_RC.8-8bd96c572_Internal   2eceb2b35b5aB  313M
docker-eventd                                      latest                           2eceb2b35b5a   313MB
docker-mux                                         202305_RC.8-8bd96c572_Internal   4a16dbfce193   362MB
docker-mux                                         latest                           4a16dbfce193   362MB
docker-lldp                                        202305_RC.8-8bd96c572_Internal   fa4ff9a1dcb6   356MB
docker-lldp                                        latest                           fa4ff9a1dcb6   356MB
docker-router-advertiser                           202305_RC.8-8bd96c572_Internal   dff00755ee31   313MB
docker-router-advertiser                           latest                           dff00755ee31   313MB
docker-database                                    202305_RC.8-8bd96c572_Internal   053ff09de423   313MB
docker-database                                    latest                           053ff09de423   313MB
docker-sonic-mgmt-framework                        202305_RC.8-8bd96c572_Internal   906da11fef08   416MB
docker-sonic-mgmt-framework                        latest                           906da11fef08   416MB

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):

@dgsudharsan dgsudharsan added Triaged this issue has been triaged NVIDIA labels Oct 25, 2023
lguohan pushed a commit that referenced this issue Dec 20, 2023
Fix the fsck check which is not working. Potentially fixes #16938
Modified fsck script to run on the ext4.fsck on the appropriate disk where SONiC resides

Microsoft ADO: 26098631
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this issue Dec 26, 2023
Fix the fsck check which is not working. Potentially fixes sonic-net#16938
Modified fsck script to run on the ext4.fsck on the appropriate disk where SONiC resides

Microsoft ADO: 26098631
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this issue Jan 29, 2024
Fix the fsck check which is not working. Potentially fixes sonic-net#16938
Modified fsck script to run on the ext4.fsck on the appropriate disk where SONiC resides

Microsoft ADO: 26098631
mssonicbld pushed a commit that referenced this issue Jan 29, 2024
Fix the fsck check which is not working. Potentially fixes #16938
Modified fsck script to run on the ext4.fsck on the appropriate disk where SONiC resides

Microsoft ADO: 26098631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NVIDIA Triaged this issue has been triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants