Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202305] [chassis]: route_check.py fails and throw traceback on Supervisor #17400

Closed
anamehra opened this issue Dec 4, 2023 · 3 comments · Fixed by sonic-net/sonic-utilities#3075
Assignees
Labels
Triaged this issue has been triaged

Comments

@anamehra
Copy link
Contributor

anamehra commented Dec 4, 2023

Description

On chassis-packet, there is no bgp running on Supervisor.
route_check.py tries to fetch the routes from frr and throws traceback when empty list is returned.

cisco@sfd-t2-sup:~$ sudo su
root@sfd-t2-sup:/home/cisco# route_check.py 
Traceback (most recent call last):
  File "/usr/local/bin/route_check.py", line 810, in <module>
    sys.exit(main()[0])
  File "/usr/local/bin/route_check.py", line 797, in main
    ret, res= check_routes()
  File "/usr/local/bin/route_check.py", line 745, in check_routes
    rt_frr_miss = check_frr_pending_routes()
  File "/usr/local/bin/route_check.py", line 537, in check_frr_pending_routes
    frr_routes = get_frr_routes()
  File "/usr/local/bin/route_check.py", line 344, in get_frr_routes
    routes = json.loads(output)
  File "/usr/lib/python3.9/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3.9/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python3.9/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Introduced by sonic-net/sonic-utilities#2762

Steps to reproduce the issue:

Describe the results you received:

Describe the results you expected:

Output of show version:

sha1 from 202305 build:
d814cc41d [eventd]: Disabling eventd tests (#17053) (#17061)

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):

@anamehra
Copy link
Contributor Author

anamehra commented Dec 4, 2023

Hi @abdosi , @gechiang , @rlhui , for your viz. Thanks

@rlhui rlhui changed the title [chassis]: route_check.py fails and throw traceback on Supervisor [202305] [chassis]: route_check.py fails and throw traceback on Supervisor Dec 13, 2023
@prabhataravind
Copy link
Contributor

@anamehra could you please own this as you have a draft PR in progress? @rlhui for viz

@prabhataravind prabhataravind added the Triaged this issue has been triaged label Dec 20, 2023
@anamehra anamehra removed their assignment Dec 20, 2023
@anamehra
Copy link
Contributor Author

@anamehra could you please own this as you have a draft PR in progress? @rlhui for viz

Hi @prabhataravind, @rlhui , please assign it back to me. I unassigned by error. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Triaged this issue has been triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants