Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert frr route check (#2761)" #2762

Conversation

stepanblyschak
Copy link
Contributor

This reverts commit 79a21ce.

DEPENDS ON: sonic-net/sonic-buildimage#12853

What I did

Reverted changes back

How I did it

Reverted changes back

How to verify it

UT

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@stepanblyschak
Copy link
Contributor Author

@StormLiangMS This reverts the revert you did. Since dependent PR is merged, could you please merge this PR and I will update submodule

@stepanblyschak stepanblyschak marked this pull request as ready for review April 21, 2023 12:34
@liat-grozovik
Copy link
Collaborator

@StormLiangMS can we go a head and merge this one? dependency PR is merged

Copy link
Contributor

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit b4f4e63 into sonic-net:master May 23, 2023
@StormLiangMS
Copy link
Contributor

@stepanblyschak we don't need to manually advance the submodule, it will done automatically and normally take one day, to create manual advance will cause unnecessary burden of CI/CD.

pdhruv-marvell pushed a commit to pdhruv-marvell/sonic-utilities that referenced this pull request Aug 23, 2023
This reverts commit 79a21ce.

DEPENDS ON: sonic-net/sonic-buildimage#12853

What I did
Reverted changes back

How I did it
Reverted changes back

How to verify it
UT
stepanblyschak added a commit to stepanblyschak/sonic-utilities that referenced this pull request Dec 19, 2023
stepanblyschak added a commit to stepanblyschak/sonic-utilities that referenced this pull request Dec 20, 2023
yxieca pushed a commit that referenced this pull request Jan 24, 2024
* Revert "[config/show] Add command to control pending FIB suppression (#2495)"

This reverts commit 9126e7f.

* Revert "Revert "Revert frr route check (#2761)" (#2762)"

This reverts commit b4f4e63.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants