Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password Hardening: Fix the support of disable expiration like in Linux (PAM) #17427

Open
davidpil2002 opened this issue Dec 6, 2023 · 1 comment

Comments

@davidpil2002
Copy link
Contributor

davidpil2002 commented Dec 6, 2023

Description

 Password Hardening: Add support to disable expiration date like in Linux:
 -1: expiration will never occur
 0: expiration will expire immediately

Steps to reproduce the issue:

sudo config passw-hardening policies expiration -1
Usage: config passw-hardening policies expiration [OPTIONS] EXPIRATION
Try "config passw-hardening policies expiration -h" for help.

Error: no such option: -1

Describe the results you received:

Recieved -1 its not exist "Error: no such option: -1", but the cracklib library that this feature used supports -1 as disabling the expiration time.

Describe the results you expected:

expect to be able to set -1 value in the expiration attribute and not expiration day will happen to the password of the users.

Output of show version:

any version

(paste your output here)

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):

@prabhataravind prabhataravind added NVIDIA Triaged this issue has been triaged labels Dec 20, 2023
liat-grozovik pushed a commit that referenced this issue Dec 25, 2023
…nux (PAM) (#17426)

- Why I did it
Enhance the feature to support disabling password hardening as Linux support.
-1: expiration will never occur
0: expiration will expired immediately

Opened bug:
#17427

- How I did it
Added the -1 value to be supported in hostcfgd and this value will propagate to the relevant Linux files

- How to verify it
Pls see the details in the bug description that link attached above
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this issue Jan 4, 2024
…nux (PAM) (sonic-net#17426)

- Why I did it
Enhance the feature to support disabling password hardening as Linux support.
-1: expiration will never occur
0: expiration will expired immediately

Opened bug:
sonic-net#17427

- How I did it
Added the -1 value to be supported in hostcfgd and this value will propagate to the relevant Linux files

- How to verify it
Pls see the details in the bug description that link attached above
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this issue Feb 2, 2024
…nux (PAM) (sonic-net#17426)

- Why I did it
Enhance the feature to support disabling password hardening as Linux support.
-1: expiration will never occur
0: expiration will expired immediately

Opened bug:
sonic-net#17427

- How I did it
Added the -1 value to be supported in hostcfgd and this value will propagate to the relevant Linux files

- How to verify it
Pls see the details in the bug description that link attached above
mssonicbld pushed a commit that referenced this issue Feb 2, 2024
…nux (PAM) (#17426)

- Why I did it
Enhance the feature to support disabling password hardening as Linux support.
-1: expiration will never occur
0: expiration will expired immediately

Opened bug:
#17427

- How I did it
Added the -1 value to be supported in hostcfgd and this value will propagate to the relevant Linux files

- How to verify it
Pls see the details in the bug description that link attached above
@davidpil2002
Copy link
Contributor Author

status:
this Issue: is still pending merge of one reference PR: sonic-net/sonic-host-services#93
(PR ready a long time ago)

required to merge PR, them close this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants