Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Yang] MACSEC_PROFILE table does not match yang definition #18418

Closed
ganglyu opened this issue Mar 21, 2024 · 0 comments
Closed

[Yang] MACSEC_PROFILE table does not match yang definition #18418

ganglyu opened this issue Mar 21, 2024 · 0 comments
Labels
YANG YANG model related changes

Comments

@ganglyu
Copy link
Contributor

ganglyu commented Mar 21, 2024

Description

MACSEC_PROFILE table is:
"MACSEC_PROFILE": {"128_SCI": {"cipher_suite": "GCM-AES-128", "policy": "security", "primary_cak": "3106080a00005b554f4e007975707670725b0a54540c0252445e5d7a29252b046a", "primary_ckn": "6162636465666768696A6B6C6D6E6F70", "priority": "64", "rekey_period": "0", "send_sci": "true"}}

There is primary_cak, and there's no fallback_cak:
https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-macsec.yang#L73

Steps to reproduce the issue:

  1. Create virtual testbed kvmtest-t0-sonic
  2. Run test macsec/test_deployment.py, check MACSEC_PROFILE table

Describe the results you received:

There is primary_cak, and there's no fallback_cak

Describe the results you expected:

MACSEC_PROFILE table should match yang definition

Output of show version:

(paste your output here)

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):

@ganglyu ganglyu added the YANG YANG model related changes label Mar 21, 2024
qiluo-msft pushed a commit that referenced this issue Mar 21, 2024
…tion (#18419)

### Why I did it
Fix the issue [18418](#18418), The YANG model to MACsec fallback cak/ckn is wrong. We should allow the fallback option is empty.

### How I did it
Add a condition to check whether the fallback is providered

#### How to verify it
Check Azp
@ganglyu ganglyu closed this as completed Mar 21, 2024
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this issue May 9, 2024
…tion (sonic-net#18419)

### Why I did it
Fix the issue [18418](sonic-net#18418), The YANG model to MACsec fallback cak/ckn is wrong. We should allow the fallback option is empty.

### How I did it
Add a condition to check whether the fallback is providered

#### How to verify it
Check Azp
mssonicbld pushed a commit that referenced this issue May 11, 2024
…tion (#18419)

### Why I did it
Fix the issue [18418](#18418), The YANG model to MACsec fallback cak/ckn is wrong. We should allow the fallback option is empty.

### How I did it
Add a condition to check whether the fallback is providered

#### How to verify it
Check Azp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
YANG YANG model related changes
Projects
None yet
Development

No branches or pull requests

1 participant