Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dhcp_server] [rsyslog] Logs are not written to host #18472

Closed
vivekrnv opened this issue Mar 26, 2024 · 7 comments
Closed

[dhcp_server] [rsyslog] Logs are not written to host #18472

vivekrnv opened this issue Mar 26, 2024 · 7 comments
Assignees
Labels
MSFT P0 Priority of the issue Triaged this issue has been triaged

Comments

@vivekrnv
Copy link
Contributor

Description

dhcp_server rsyslog container plugin is not writing logs to host. Logs are written to /var/log/syslog under the container

Steps to reproduce the issue:

  1. Run https://github.com/sonic-net/sonic-mgmt/blob/master/tests/process_monitoring/test_critical_process_monitoring.py to easily repro the issue
  2. or start the dhcp_server and see nothing is written to syslog

Describe the results you received:

Expected Messages that are missing:
.*Process 'dhcpservd' is not running in namespace 'host'.*
.*Process 'kea-dhcp4' is not running in namespace 'host'.*

Describe the results you expected:

Logs should be written correctly

@vivekrnv
Copy link
Contributor Author

@yxieca, @yaqiangz PFA

@yaqiangz
Copy link
Contributor

yaqiangz commented Mar 27, 2024

@yxieca, @yaqiangz PFA

@vivekrnv It's a known issue, dhcp_server container is running on bridge network mode. For now, syslog of it can be found in /etc/log/syslog inside container

@prgeor prgeor added Triaged this issue has been triaged P0 Priority of the issue MSFT labels Mar 27, 2024
@prgeor
Copy link
Contributor

prgeor commented Mar 27, 2024

@yaqiangz this is not expected behavior. All the dhcp_server logs must be logged on the host /var/log because

  1. We need log rotation to work which runs in the host, in order to avoid disk getting full overtime
  2. Also this may cause disk wear out over time

@Blueve Can you please prioritize this P0 MUST fix

@Blueve
Copy link
Contributor

Blueve commented Mar 28, 2024

@prgeor we might not have enough capacity until June.

@vivekrnv can you purpose a fix if this is urgent? we can help review.

@Blueve Blueve closed this as completed Mar 28, 2024
@vivekrnv vivekrnv reopened this Apr 9, 2024
@vivekrnv
Copy link
Contributor Author

vivekrnv commented Apr 9, 2024

@Blueve, I currently don't have BW to work on this. Please don't close the issue as the problem still exists and also the test process_monitoring/test_critical_process_monitoring.py fails when the dhcp server is enabled

@Blueve
Copy link
Contributor

Blueve commented May 10, 2024

Update ETA: 30 June

yxieca pushed a commit that referenced this issue Jun 26, 2024
Why I did it
Fix issue that dhcp_server doesn't create syslog into host #18472

Work item tracking
Microsoft ADO (number only): 28396389
How I did it
Modify rsyslog config template

How to verify it
UTs passed
Buildimage and install in testbed to verify
@yaqiangz
Copy link
Contributor

#19303
Fixed
@vivekrnv for viz

yaqiangz added a commit to yaqiangz/sonic-buildimage that referenced this issue Jun 27, 2024
…19303)

Why I did it
Fix issue that dhcp_server doesn't create syslog into host sonic-net#18472

Work item tracking
Microsoft ADO (number only): 28396389
How I did it
Modify rsyslog config template

How to verify it
UTs passed
Buildimage and install in testbed to verify
yxieca pushed a commit that referenced this issue Jul 1, 2024
…19410)

* [202311][dhcp_server] Add rsyslog support for dhcp_server (#19303)

Why I did it
Fix issue that dhcp_server doesn't create syslog into host #18472

Work item tracking
Microsoft ADO (number only): 28396389
How I did it
Modify rsyslog config template

How to verify it
UTs passed
Buildimage and install in testbed to verify

* Update ut

* Update uts
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this issue Jul 9, 2024
Why I did it
Fix issue that dhcp_server doesn't create syslog into host sonic-net#18472

Work item tracking
Microsoft ADO (number only): 28396389
How I did it
Modify rsyslog config template

How to verify it
UTs passed
Buildimage and install in testbed to verify
mssonicbld pushed a commit that referenced this issue Jul 12, 2024
Why I did it
Fix issue that dhcp_server doesn't create syslog into host #18472

Work item tracking
Microsoft ADO (number only): 28396389
How I did it
Modify rsyslog config template

How to verify it
UTs passed
Buildimage and install in testbed to verify
arun1355492 pushed a commit to arun1355492/sonic-buildimage that referenced this issue Jul 26, 2024
Why I did it
Fix issue that dhcp_server doesn't create syslog into host sonic-net#18472

Work item tracking
Microsoft ADO (number only): 28396389
How I did it
Modify rsyslog config template

How to verify it
UTs passed
Buildimage and install in testbed to verify
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this issue Aug 1, 2024
Why I did it
Fix issue that dhcp_server doesn't create syslog into host sonic-net#18472

Work item tracking
Microsoft ADO (number only): 28396389
How I did it
Modify rsyslog config template

How to verify it
UTs passed
Buildimage and install in testbed to verify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MSFT P0 Priority of the issue Triaged this issue has been triaged
Projects
None yet
Development

No branches or pull requests

4 participants