-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[virtual-switch] Port config ini type for portsyncd hardcoded #1990
Comments
this leads to another issue that when executing |
@taoyl-ms currently vs can only support Force10-S6000 port_config ini. as long as the vs has 32 ports, we do not need to change that. What is the issue you are facing? |
So you mean to say that vs cannot support Arista devices as of now? |
The correct solution should be renaming the platform name to a vs-specific name and let create symbol links for vs-supported skus under it. Reusing the Force10 platform string for virtual switch is confusing. |
@taoyl-ms agree. |
@NehaRajeM , it can support arista device. @taoyl-ms , we have discussed the separate the alias from port_config.ini for virtual switch. any progress on that? |
We have different hwskus on vs now. this issue has been addressed. |
Commits: f147d9e - 2021-10-27 : [Mux orch] Handle setting unknown mux state (#1984) [Prince Sunny] 4618b2b - 2021-10-28 : Change tunnel orch order (#1990) [Prince Sunny] 505d52d - 2021-10-20 : Fix the option missing in kernel config issue (#1973) [xumia] 7bf4dfb - 2021-10-18 : SAI_REDIS_SWITCH_ATTR_CONTEXT shouldbe the last attribute. This is what sairedis library expects (#1935) [judyjoseph] c58919e - 2021-10-08 : [logfile][202012]: Add option to specify swss rec file name (#1946) [judyjoseph]
port_config.ini hardcoded for Force10 routers in supervisord.conf for virtual switch.
https://github.com/Azure/sonic-buildimage/blob/master/platform/vs/docker-sonic-vs/supervisord.conf
[program:portsyncd]
command=/usr/bin/portsyncd -p /usr/share/sonic/device/x86_64-dell_s6000_s1220-r0/Force10-S6000/port_config.ini
priority=6
autostart=false
autorestart=false
stdout_logfile=syslog
stderr_logfile=syslog
Expected: based on the hwsku/platform set, the appropriate port_config.ini should be selected.
The text was updated successfully, but these errors were encountered: