Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get into sonic-slave docker #2029

Closed
wendani opened this issue Sep 9, 2018 · 6 comments
Closed

Get into sonic-slave docker #2029

wendani opened this issue Sep 9, 2018 · 6 comments
Assignees
Labels

Comments

@wendani
Copy link
Contributor

wendani commented Sep 9, 2018

Description
make KEEP_SLAVE_ON=yes SOURCE_FOLDER=/home/localadmin target/sonic-aboot-broadcom.swi

does not get into the slave docker for kernel 4.9.0-7-amd64

Steps to reproduce the issue:

  1. make target/sonic-aboot-broadcom.swi
  2. make KEEP_SLAVE_ON=yes SOURCE_FOLDER=/home/localadmin target/sonic-aboot-broadcom.swi

Describe the results you received:

Describe the results you expected:

Additional information you deem important (e.g. issue happens only occasionally):

**Output of `show version`:**

```
(paste your output here)
```

**Attach debug file `sudo generate_dump`:**

```
(paste your output here)
```
@yxieca
Copy link
Contributor

yxieca commented Sep 10, 2018

This is a known issue with stretch build.

The reason we want to keep slave on is usually because we want to build something incrementally, or retry part of the build quickly.

With stretch, one has to be consciously know which slave docker to stay on:

If the intention is to stay in the stretch docker, then issue "make stretch KEEP_SLAVE_ON=yes"
If the intention is to stay in the jessy docker, then issue "make stretch" to complete stretch build first, then issue "make NOSTETCH=1 KEEP_SLAVE_ON=yes [target] to stay in the jessy docker.

This is an interim inconvenience until we move all dockers to stretch. It might be better fixed with updating document than fixing the make file itself.

Cheers,
Ying

@wendani
Copy link
Contributor Author

wendani commented Sep 10, 2018

Which docker shall I choose if I build the opennsl and saibcm?

@nikos-github
Copy link
Collaborator

@wendani If I'm not mistaken, the point being made above is illustrating how to keep the slave docker on when you use stretch (the default), and when you use jessie (the non-default). Chances are you are building using the default (stretch), so I would follow that.

@yxieca
Copy link
Contributor

yxieca commented Sep 11, 2018

@wendani For current Broadcom SAI release 3.1, you want to stay on Jessie docker for the build. And you don't want to use 4.9 kernel headers, you want to use 3.16 kernel headers. So it makes more sense for you to use an older branch, e.g. 201803 for this purpose.

@wendani
Copy link
Contributor Author

wendani commented Sep 11, 2018

@yxieca Thanks I have problem building opennsl 3.4.1.11-1 (failed), which uses linux headers 3.16.0-4. However, I donot have 3.16.0-4 header pkg in the target/debs, only 3.16.0-5

@yxieca
Copy link
Contributor

yxieca commented Sep 11, 2018

@wendani You can copy the header files from Jenkins, like 201803 build. Or you can start you build from 201803 branch.

@lguohan lguohan closed this as completed Sep 12, 2018
stephenxs added a commit to stephenxs/sonic-buildimage that referenced this issue Dec 1, 2021
d352d5a Update default route status to state DB (sonic-net#2009)
24a64d6 Orchagent: Integrate P4Orch (sonic-net#2029)

Signed-off-by: Stephen Sun <stephens@nvidia.com>
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this issue Feb 5, 2022
* Orchagent: Integrate P4Orch
* support pushing switch configurations.
* support ACL table definitions.
* support insert/delete/modify in APPL_DB.
* support for L3 forwarding, WCMP, and ACL tables.
* support for response path through APPL_STATE_DB.

Co-authored-by: PINS Working Group <sonic-pins-subgroup@googlegroups.com>
taras-keryk pushed a commit to taras-keryk/sonic-buildimage that referenced this issue Apr 28, 2022
sonic-net#2092)

#### What I did
Fixes sonic-net#2029 sonic-net#2062

Changes to fields under BGP_PEER_RANGE, BGP_MONITORS using GCU are not reflected unless each key is deleted and added back. This means the fields are create-only.

#### How I did it
Marked the fields under BGP_PEER_RANGE, BGP_MONITORS as create-only

#### How to verify it
unit-test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants