Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pcie-check.sh] Incorrect command in pcie-check.sh #6676

Closed
bingwang-ms opened this issue Feb 4, 2021 · 0 comments · Fixed by #6682
Closed

[pcie-check.sh] Incorrect command in pcie-check.sh #6676

bingwang-ms opened this issue Feb 4, 2021 · 0 comments · Fixed by #6682
Labels
Bug 🐛 Master Branch Quality

Comments

@bingwang-ms
Copy link
Contributor

Description
pcie-check.sh is reporting errors because incorrect command.

 3253 Feb  3 23:07:17.736780 str-7260cx3-acs-2 INFO pcie-check.sh[1001]: Usage: pcieutil [OPTIONS] COMMAND [ARGS]...                                                                                   
 3254 Feb  3 23:07:17.736922 str-7260cx3-acs-2 INFO pcie-check.sh[1001]: Try "pcieutil --help" for help.
 3255 Feb  3 23:07:17.737276 str-7260cx3-acs-2 INFO pcie-check.sh[1001]: Error: No such command "pcie-check".

It's because PR #1297 updated subcommand of pcieutil, but pcie-check.sh script is not updated yet.

Steps to reproduce the issue:

  1. Run pcie-check.sh

Describe the results you received:
No errors should be seen.

Describe the results you expected:
Errors are observed when running pcie-check.sh.

Additional information you deem important (e.g. issue happens only occasionally):

**Output of `show version`:**

SONiC Software Version: SONiC.HEAD.339-5c8b70ea
Distribution: Debian 10.7
Kernel: 4.19.0-9-2-amd64
Build commit: 5c8b70ea
Build date: Tue Feb  2 02:33:34 UTC 2021
Built by: johnar@jenkins-worker-22

Platform: x86_64-arista_7260cx3_64
HwSKU: Arista-7260CX3-D108C8
ASIC: broadcom
ASIC Count: 1
Serial Number: SSJ17432414
Uptime: 02:31:20 up  3:01,  1 user,  load average: 2.80, 2.95, 3.50

Docker images:
REPOSITORY                    TAG                 IMAGE ID            SIZE
docker-fpm-frr                HEAD.339-5c8b70ea   f3c9e3af45ae        427MB
docker-fpm-frr                latest              f3c9e3af45ae        427MB
docker-snmp                   HEAD.339-5c8b70ea   b400adc665fe        438MB
docker-snmp                   latest              b400adc665fe        438MB
docker-syncd-brcm             HEAD.339-5c8b70ea   3cdf85f51e97        679MB
docker-syncd-brcm             latest              3cdf85f51e97        679MB
docker-teamd                  HEAD.339-5c8b70ea   500b6b47959d        408MB
docker-teamd                  latest              500b6b47959d        408MB
docker-router-advertiser      HEAD.339-5c8b70ea   cff46295d07e        397MB
docker-router-advertiser      latest              cff46295d07e        397MB
docker-platform-monitor       HEAD.339-5c8b70ea   6b9a0beca7a2        605MB
docker-platform-monitor       latest              6b9a0beca7a2        605MB
docker-macsec                 HEAD.339-5c8b70ea   43cc58ffeecc        411MB
docker-macsec                 latest              43cc58ffeecc        411MB
docker-lldp                   HEAD.339-5c8b70ea   9e76d9751a62        437MB
docker-lldp                   latest              9e76d9751a62        437MB
docker-dhcp-relay             HEAD.339-5c8b70ea   d2f9996298b3        404MB
docker-dhcp-relay             latest              d2f9996298b3        404MB
docker-database               HEAD.339-5c8b70ea   a5e285ed330f        397MB
docker-database               latest              a5e285ed330f        397MB
docker-sonic-mgmt-framework   HEAD.339-5c8b70ea   83f9a5f79f47        615MB
docker-sonic-mgmt-framework   latest              83f9a5f79f47        615MB
docker-orchagent              HEAD.339-5c8b70ea   a6aa19dd2381        426MB
docker-orchagent              latest              a6aa19dd2381        426MB
docker-nat                    HEAD.339-5c8b70ea   8e925ec8392f        411MB
docker-nat                    latest              8e925ec8392f        411MB
docker-sonic-telemetry        HEAD.339-5c8b70ea   77e2f48bbe40        472MB
docker-sonic-telemetry        latest              77e2f48bbe40        472MB
docker-sflow                  HEAD.339-5c8b70ea   928f9bdd6490        408MB
docker-sflow                  latest              928f9bdd6490        408MB

**Attach debug file `sudo generate_dump`:**

```
(paste your output here)
```
@bingwang-ms bingwang-ms mentioned this issue Feb 4, 2021
Closed
4 tasks
@jleveque jleveque mentioned this issue Feb 4, 2021
Merged
4 tasks
lguohan pushed a commit that referenced this issue Feb 4, 2021
@jleveque
[pcie-check] Update underlying pcieutil command and add to sudoers fi…
820d350 
…le (#6682)

- Why I did it

As of sonic-net/sonic-utilities#1297, subcommands of pcieutil have changed to remove the redundant pcie- prefix. This PR adapts calling applications (pcie-check) to the new syntax.

Resolves #6676

- How I did it

Remove pcie- prefix from pcieutil subcommands in calling applications
Also add pcieutil * to sudoers file, as pcieutil requires elevated permissions
daall pushed a commit that referenced this issue Feb 5, 2021
@jleveque @daall
[pcie-check] Update underlying pcieutil command and add to sudoers fi…
57a6fb9 
…le (#6682)

- Why I did it

As of sonic-net/sonic-utilities#1297, subcommands of pcieutil have changed to remove the redundant pcie- prefix. This PR adapts calling applications (pcie-check) to the new syntax.

Resolves #6676

- How I did it

Remove pcie- prefix from pcieutil subcommands in calling applications
Also add pcieutil * to sudoers file, as pcieutil requires elevated permissions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐛 Master Branch Quality
Projects
None yet
Milestone
No milestone
1 participant
@bingwang-ms