Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate_acl invalid TCP_FLAGS issue #696

Closed
stcheng opened this issue Jun 13, 2017 · 1 comment
Closed

translate_acl invalid TCP_FLAGS issue #696

stcheng opened this issue Jun 13, 2017 · 1 comment
Labels

Comments

@stcheng
Copy link
Contributor

stcheng commented Jun 13, 2017

        "ACL_RULE_TABLE:search_global_outbound_acl:Rule_1":{
            "IP_PROTOCOL":6,
            "PACKET_ACTION":"FORWARD",
            "TCP_FLAGS":"0x10",
            "priority":9999
        },
        "OP":"SET"

will trigger ERR orchagent: :- validateAddMatch: Invalid TCP flags format 0x10 as in orchagent, if (flagsData.size() != 2) // expect two parts flags and mask separated with '/'.

@stcheng
Copy link
Contributor Author

stcheng commented Jun 13, 2017

#697 resolved

@stcheng stcheng closed this as completed Jun 13, 2017
lguohan added a commit to lguohan/sonic-buildimage that referenced this issue Nov 22, 2018
sairedis:
 * d146572 2018-11-22 | Fix interface name used on link message using lane map (sonic-net#386)

swss:
* c74dc60 2018-11-22 | [vstest]: use eth1~32 as physical interface name in vs docker (sonic-net#700) (HEAD -> master, origin/master, origin/HEAD) [lguohan]
* 6007e7f 2018-11-22 | [portmgrd]: Fix setting default port admin status and MTU (sonic-net#691) [stepanblyschak]
* 6c70f6d 2018-11-22 | [portsorch] Fix port queue index init bug (sonic-net#505) [yangbashuang]
* 70ac79b 2018-11-21 | [gitignore]: Update all binary names in the ignore list (sonic-net#698) [Shuotian Cheng]
* 2a3626c 2018-11-21 | [test]: Remove duplicate legacy ACL tests (sonic-net#699) [Shuotian Cheng]
* 8099811 2018-11-20 | [aclorch]: Remove unnecessary warning message (sonic-net#696) [Shuotian Cheng]
* 63d8ebc 2018-11-18 | [portsorch]: Remove duplicate local variables - port (sonic-net#690) [Shuotian Cheng]
* 28dc042 2018-11-18 | Remove default docker name value of swss. (sonic-net#692) [Jipan Yang]

Signed-off-by: Guohan Lu <gulv@microsoft.com>
lguohan added a commit that referenced this issue Nov 22, 2018
* syncd changes to disk and add e1000 driver to sonic vm

* add pg_profile_lookup.ini

Signed-off-by: Guohan Lu <gulv@microsoft.com>

* update swss and sairedis

sairedis:
 * d146572 2018-11-22 | Fix interface name used on link message using lane map (#386)

swss:
* c74dc60 2018-11-22 | [vstest]: use eth1~32 as physical interface name in vs docker (#700) (HEAD -> master, origin/master, origin/HEAD) [lguohan]
* 6007e7f 2018-11-22 | [portmgrd]: Fix setting default port admin status and MTU (#691) [stepanblyschak]
* 6c70f6d 2018-11-22 | [portsorch] Fix port queue index init bug (#505) [yangbashuang]
* 70ac79b 2018-11-21 | [gitignore]: Update all binary names in the ignore list (#698) [Shuotian Cheng]
* 2a3626c 2018-11-21 | [test]: Remove duplicate legacy ACL tests (#699) [Shuotian Cheng]
* 8099811 2018-11-20 | [aclorch]: Remove unnecessary warning message (#696) [Shuotian Cheng]
* 63d8ebc 2018-11-18 | [portsorch]: Remove duplicate local variables - port (#690) [Shuotian Cheng]
* 28dc042 2018-11-18 | Remove default docker name value of swss. (#692) [Jipan Yang]

Signed-off-by: Guohan Lu <gulv@microsoft.com>
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this issue Mar 23, 2020
Because AclOrch listens to all notifications from PortsOrch,
every time LAG member changes the change message will be sent to
AclOrch which is unncessary. This warning message is not wanted.

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant