Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[crm] error in logs querying for SAI_OBJECT_TYPE_INSEG_ENTRY #8036

Open
stepanblyschak opened this issue Jul 1, 2021 · 6 comments
Open

[crm] error in logs querying for SAI_OBJECT_TYPE_INSEG_ENTRY #8036

stepanblyschak opened this issue Jul 1, 2021 · 6 comments
Labels
Triaged this issue has been triaged

Comments

@stepanblyschak
Copy link
Collaborator

stepanblyschak commented Jul 1, 2021 •
edited
Loading

Description

Errors in logs querying for SAI_OBJECT_TYPE_INSEG_ENTRY found on switch that does not support them.

Steps to reproduce the issue:

  1. Boot switch and show log -f | grep ERR

Describe the results you received:

Jul  1 14:24:02.920814 r-ocelot-02 NOTICE swss#orchagent: :- getResAvailableCounters: Switch attribute 61 not supported
Jul  1 14:24:02.921541 r-ocelot-02 NOTICE swss#orchagent: :- getResAvailableCounters: Switch attribute 62 not supported
Jul  1 14:24:02.922530 r-ocelot-02 NOTICE swss#orchagent: :- getResAvailableCounters: Switch attribute 63 not supported
Jul  1 14:24:02.923467 r-ocelot-02 ERR swss#orchagent: :- getResAvailableCounters: Failed to get availability for object_type 63 , rv:-5

rv:-5 means SAI_STATUS_INVALID_PARAMETER - this is our SAI issue which will be resolved but in any case the current code does not check for not supported/not implemented values:

https://github.com/Azure/sonic-swss/blob/master/orchagent/crmorch.cpp#L557

sai_status_t status = sai_object_type_get_availability(gSwitchId, objType, 0, nullptr, &availCount);
if (status != SAI_STATUS_SUCCESS)
{
    SWSS_LOG_ERROR("Failed to get availability for object_type %u , rv:%d", objType, status);
    break;
}

Describe the results you expected:

Jul  1 14:24:02.920814 r-ocelot-02 NOTICE swss#orchagent: :- getResAvailableCounters: Switch attribute 61 not supported
Jul  1 14:24:02.921541 r-ocelot-02 NOTICE swss#orchagent: :- getResAvailableCounters: Switch attribute 62 not supported
Jul  1 14:24:02.922530 r-ocelot-02 NOTICE swss#orchagent: :- getResAvailableCounters: Switch attribute 63 not supported
Jul  1 14:24:02.923467 r-ocelot-02 NOTICE swss#orchagent: :- getResAvailableCounters: Resource MPLS_INSEG is not supported

Output of show version:

SONiC Software Version: SONiC.HEAD.764-dirty-20210701.083821
Distribution: Debian 10.10
Kernel: 4.19.0-12-2-amd64
Build commit: 90801dc1b
Build date: Thu Jul  1 12:32:43 UTC 2021
Built by: sw-r2d2-bot@r-build-sonic-ci02

Platform: x86_64-mlnx_msn4410-r0
HwSKU: ACS-MSN4410
ASIC: mellanox
ASIC Count: 1
Serial Number: MT2039X06760
Model Number: MSN4410-WS2FO
Hardware Revision: A1
Uptime: 15:16:42 up 58 min,  1 user,  load average: 0.10, 0.19, 0.18

Docker images:
REPOSITORY                    TAG                              IMAGE ID            SIZE
docker-syncd-mlnx             HEAD.764-dirty-20210701.083821   04e8f880cd07        962MB
docker-syncd-mlnx             latest                           04e8f880cd07        962MB
docker-snmp                   HEAD.764-dirty-20210701.083821   dd52c0977a70        454MB
docker-snmp                   latest                           dd52c0977a70        454MB
docker-teamd                  HEAD.764-dirty-20210701.083821   1a2601e4abb9        424MB
docker-teamd                  latest                           1a2601e4abb9        424MB
docker-nat                    HEAD.764-dirty-20210701.083821   0ec4e89ad716        427MB
docker-nat                    latest                           0ec4e89ad716        427MB
docker-router-advertiser      HEAD.764-dirty-20210701.083821   2bf74fa57500        413MB
docker-router-advertiser      latest                           2bf74fa57500        413MB
docker-platform-monitor       HEAD.764-dirty-20210701.083821   5e3b3c39305d        739MB
docker-platform-monitor       latest                           5e3b3c39305d        739MB
docker-lldp                   HEAD.764-dirty-20210701.083821   f6e49628cec1        453MB
docker-lldp                   latest                           f6e49628cec1        453MB
docker-dhcp-relay             HEAD.764-dirty-20210701.083821   d84a0995140a        420MB
docker-dhcp-relay             latest                           d84a0995140a        420MB
docker-orchagent              HEAD.764-dirty-20210701.083821   3836dd5edda2        443MB
docker-orchagent              latest                           3836dd5edda2        443MB
docker-macsec                 HEAD.764-dirty-20210701.083821   59ff437f3327        428MB
docker-macsec                 latest                           59ff437f3327        428MB
docker-sonic-telemetry        HEAD.764-dirty-20210701.083821   bbe65775971e        501MB
docker-sonic-telemetry        latest                           bbe65775971e        501MB
docker-sonic-mgmt-framework   HEAD.764-dirty-20210701.083821   008e79a68750        570MB
docker-sonic-mgmt-framework   latest                           008e79a68750        570MB
docker-fpm-frr                HEAD.764-dirty-20210701.083821   9ed2732d8a0a        443MB
docker-fpm-frr                latest                           9ed2732d8a0a        443MB
docker-database               HEAD.764-dirty-20210701.083821   93146d6ba0b4        413MB
docker-database               latest                           93146d6ba0b4        413MB
docker-sflow                  HEAD.764-dirty-20210701.083821   c602d16cc40f        425MB
docker-sflow                  latest                           c602d16cc40f        425MB

Output of show techsupport:

Additional information you deem important (e.g. issue happens only occasionally):

sonic_dump_r-ocelot-02_20210701_151705.tar.gz
@vaibhavhd
Copy link
Contributor

This is likely a duplicate of #7933

@stepanblyschak
Copy link
Collaborator Author

@vaibhavhd this is different issue from what I can see.

@prsunny
Copy link
Contributor

prsunny commented Jul 12, 2021

@qbdwlr, can you look into this issue? We have to first check on the capability for CRM_MPLS_INSEG (Introduced by sonic-net/sonic-swss#1686). @smaheshm for visibility.

@qbdwlr
Copy link
Contributor

qbdwlr commented Jul 12, 2021 •
edited
Loading

@stepanblyschak @prsunny This issue is resolved by sonic-net/sonic-sairedis#824
The sonic-sairedis submodule in sonic-buildimage was not updated until #8043 which is after the build date of the version in this issue.

@Junchao-Mellanox
Copy link
Collaborator

I still see this issue on latest master, hash c89b62e.

Jul 20 08:06:04.617027 sonic ERR swss#orchagent: :- getResAvailableCounters: Failed to get availability for object_type 63 , rv:-15

SONiC Software Version: SONiC.master.164-c89b62e4d_Internal
Distribution: Debian 10.10
Kernel: 4.19.0-12-2-amd64
Build commit: c89b62e4d
Build date: Mon Jul 19 11:52:39 UTC 2021
Built by: sw-r2d2-bot@r-build-sonic02-006

Platform: x86_64-mlnx_msn2700-r0
HwSKU: Mellanox-SN2700
ASIC: mellanox
ASIC Count: 1
Serial Number: MT2020T04244
Model Number: MSN2700-CS2FO
Hardware Revision: A2
Uptime: 08:31:00 up 31 min,  1 user,  load average: 3.02, 2.94, 2.47

Docker images:
REPOSITORY                    TAG                             IMAGE ID            SIZE
docker-dhcp-relay             latest                          686785c81783        420MB
docker-syncd-mlnx             latest                          bc04841bed8d        963MB
docker-syncd-mlnx             master.164-c89b62e4d_Internal   bc04841bed8d        963MB
docker-sflow                  latest                          f994144320ad        425MB
docker-sflow                  master.164-c89b62e4d_Internal   f994144320ad        425MB
docker-snmp                   latest                          a18c80c5db8e        454MB
docker-snmp                   master.164-c89b62e4d_Internal   a18c80c5db8e        454MB
docker-teamd                  latest                          159cee436dec        424MB
docker-teamd                  master.164-c89b62e4d_Internal   159cee436dec        424MB
docker-platform-monitor       latest                          ecd27e1ccb45        740MB
docker-platform-monitor       master.164-c89b62e4d_Internal   ecd27e1ccb45        740MB
docker-router-advertiser      latest                          110db9199230        413MB
docker-router-advertiser      master.164-c89b62e4d_Internal   110db9199230        413MB
docker-lldp                   latest                          b77501eeae3b        453MB
docker-lldp                   master.164-c89b62e4d_Internal   b77501eeae3b        453MB
docker-database               latest                          85ba1a0f1aa6        413MB
docker-database               master.164-c89b62e4d_Internal   85ba1a0f1aa6        413MB
docker-sonic-mgmt-framework   latest                          8a299b9c6c6f        569MB
docker-sonic-mgmt-framework   master.164-c89b62e4d_Internal   8a299b9c6c6f        569MB
docker-orchagent              latest                          665ac0634b1d        443MB
docker-orchagent              master.164-c89b62e4d_Internal   665ac0634b1d        443MB
docker-nat                    latest                          1289ecb19cb8        427MB
docker-nat                    master.164-c89b62e4d_Internal   1289ecb19cb8        427MB
docker-sonic-telemetry        latest                          c6af4f8a5aa6        501MB
docker-sonic-telemetry        master.164-c89b62e4d_Internal   c6af4f8a5aa6        501MB
docker-macsec                 latest                          2134fe8f7df9        428MB
docker-macsec                 master.164-c89b62e4d_Internal   2134fe8f7df9        428MB
docker-fpm-frr                latest                          dcb4e521e750        443MB
docker-fpm-frr                master.164-c89b62e4d_Internal   dcb4e521e750        443MB
docker-sonic-restapi          latest                          2c135713854f        355MB
docker-sonic-restapi          master.164-c89b62e4d_Internal   2c135713854f        355MB

@qbdwlr
Copy link
Contributor

qbdwlr commented Jul 20, 2021 •
edited
Loading

@Junchao-Mellanox I didn't realize that Mellanox platform was being tested here... I mistakenly assumed that this was seen testing VS platform. Clearly Mellanox does not have any support for this type of resource in its SAI implementation and this error will continue until it does. It is not clear why this resource is being polled in the absence of any MPLS configuration. I will submit a PR to check for NOT_IMPLEMENTED/NOT_SUPPORTED return status (presumably Mellanox SAI will return one of these from sai_object_type_get_availability() for this resource type) and output a more appropriate log message for this status.

@qbdwlr qbdwlr mentioned this issue Jul 20, 2021
Merged
qbdwlr added a commit to qbdwlr/sonic-swss that referenced this issue Jul 20, 2021
@qbdwlr
[crm] Fix for Issue sonic-net/sonic-buildimage#8036
dccd9f7
@zhangyanzhao zhangyanzhao added the Triaged this issue has been triaged label Jul 21, 2021
prsunny pushed a commit to sonic-net/sonic-swss that referenced this issue Aug 3, 2021
@qbdwlr
[crm] Fix for Issue sonic-net/sonic-buildimage#8036 (#1829)
72a72f8 
*Added more appropriate log message for CRM queries of MPLS_INSEG and MPLS_NEXTHOP resources when platform does not support these resource types.
qiluo-msft added a commit to qiluo-msft/sonic-swss that referenced this issue Aug 4, 2021
@qiluo-msft
Revert "[crm] Fix for Issue sonic-net/sonic-buildimage#8036 (sonic-ne…
d2a67ad 
…t#1829)"

This reverts commit 72a72f8.
@gechiang gechiang mentioned this issue Aug 4, 2021
Merged
gechiang pushed a commit that referenced this issue Aug 5, 2021
@Praveen-Brcm
Updating sonic-swss submodule (#8340)
1bc3fdb 
Mclag enhacements support code changes. (#1331)
[crm] Fix for Issue #8036 (#1829)
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this issue Aug 7, 2021
@Praveen-Brcm
Updating sonic-swss submodule (sonic-net#8340)
f1f4e43 
Mclag enhacements support code changes. (sonic-net#1331)
[crm] Fix for Issue sonic-net#8036 (sonic-net#1829)
judyjoseph pushed a commit to sonic-net/sonic-swss that referenced this issue Sep 2, 2021
@qbdwlr @judyjoseph
[crm] Fix for Issue sonic-net/sonic-buildimage#8036 (#1829)
fce0c60 
*Added more appropriate log message for CRM queries of MPLS_INSEG and MPLS_NEXTHOP resources when platform does not support these resource types.
judyjoseph added a commit that referenced this issue Sep 2, 2021
@judyjoseph
Submodule updates
1ca6dc9 
sonic-swss

73f6f68 [Flex Counters] Delay flex counters even if tables are present in the DB (#1877)
5edb9e5 [buffer orch] Bugfix: Don't query counter SAI_BUFFER_POOL_STAT_XOFF_ROOM_WATERMARK_BYTES on a pool where it is not supported (#1857)
fce0c60 [crm] Fix for Issue #8036 (#1829)

sonic-utilities

2630ac1 [Fast-reboot] Set flex counters delay indicator to prevent flex counters enablement after fast-reboot (#1768)
606f1b1 [portstat pfcstat] Unify the packet number format in the output of portstat and pfcstat in all cases (#1755)
2c6a15e [ecnconfig] Fix exception seen during display and add unit tests (#1784)
9b1995e Fix logic in RIF counters print (#1732)

sonic-swss-comon

3e7b81f Add a new field for FLEX_COUNTER_TABLE to indicate delay for flex counters (#523)
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-swss that referenced this issue Oct 5, 2021
@qbdwlr @raphaelt-nvidia
[crm] Fix for Issue sonic-net/sonic-buildimage#8036 (sonic-net#1829)
9bdc253 
*Added more appropriate log message for CRM queries of MPLS_INSEG and MPLS_NEXTHOP resources when platform does not support these resource types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Triaged this issue has been triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@zhangyanzhao @prsunny @vaibhavhd @stepanblyschak @qbdwlr @Junchao-Mellanox