Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build] marvell-arm64 build redis_dump_load-1.1-py2-none-any.whl fail #9216

Closed
seanwu-ec opened this issue Nov 10, 2021 · 0 comments · Fixed by #14375
Closed

[Build] marvell-arm64 build redis_dump_load-1.1-py2-none-any.whl fail #9216

seanwu-ec opened this issue Nov 10, 2021 · 0 comments · Fixed by #14375
Assignees
@isabelladeleon12 @qiluo-msft
Labels
Triaged this issue has been triaged

Comments

@seanwu-ec
Copy link
Contributor

seanwu-ec commented Nov 10, 2021 •
edited
Loading

Description

Build redis_dump_load-1.1-py2-none-any.whl fail while building marvell-arm64. Please see the full log below.
I realized that redis has removed support for end-of-life Python 2.7 redis/redis-py#1318 since v4.0.0b1. Somehow setuptool acquired redis 4.0.0rc1 while performing python2 setup.py test and trigger the error.

CHANGE SUGGESTION:

Steps to reproduce the issue:

Instruction from Marvell

  1. $ git clone https://github.com/Azure/sonic-buildimage.git
  2. $ cd sonic-buildimage
  3. $ git checkout d0c73b0
  4. $ make init
  5. $ wget https://raw.githubusercontent.com/Marvell-switching/sonic-scripts/master/sonic_master_falcon_mvl_patch.sh
  6. $ bash sonic_master_falcon_mvl_patch.sh
  7. $ make configure PLATFORM=marvell-arm64 PLATFORM_ARCH=arm64
  8. $ make target/sonic-marvell-arm64.bin

Describe the results you received:

Full build log:
build_redis_dump_load_fail.txt
@zhangyanzhao zhangyanzhao added the Triaged this issue has been triaged label Nov 10, 2021
pphuchar added a commit to SONIC-DEV/sonic-buildimage that referenced this issue Apr 6, 2022
@pphuchar
[sonic-slave] Add py2 redis for redis_dump_load
69d3dfb 
  Fix sonic-net#9216
  Redis deprecate py2 support, install redis py2 version explicitly.
@isabelladeleon12 isabelladeleon12 mentioned this issue Mar 21, 2023
Merged
8 tasks
qiluo-msft pushed a commit that referenced this issue Mar 27, 2023
@isabelladeleon12
[Build] Fix marvell-arm64 build redis_dump_load-1.1-py2-none-any.whl …
7469574 
…fail (#14375)

#### Why I did it
Fixes #9216
#### How I did it
Add support for python2 redis to the sonic-slave-stretch and sonic-slave-buster Dockerfiles
#### How to verify it
Run build steps documented in Issue #9216
lixiaoyuner pushed a commit to lixiaoyuner/sonic-buildimage that referenced this issue Feb 6, 2024
@yejianquan
Merged PR 7894273: Fix the conflict of sonic-net#14371
95e3f0a 
https://msazure.visualstudio.com/One/_workitems/edit/17813211

Related work items: sonic-net#9216, sonic-net#11437, sonic-net#13507, sonic-net#13512, sonic-net#13567, sonic-net#13972, sonic-net#14351, sonic-net#14371, sonic-net#14375, sonic-net#14401, sonic-net#14407, sonic-net#14408, sonic-net#14427, sonic-net#14428, sonic-net#14439
lixiaoyuner pushed a commit to lixiaoyuner/sonic-buildimage that referenced this issue Feb 6, 2024
@yejianquan
Merged PR 7915643: Fix the conflict of sonic-net#14371
d79fd1b 
Related work items: sonic-net#9216, sonic-net#11437, sonic-net#13507, sonic-net#13512, sonic-net#13567, sonic-net#13972, sonic-net#14351, sonic-net#14371, sonic-net#14375, sonic-net#14401, sonic-net#14407, sonic-net#14408, sonic-net#14427, sonic-net#14428, sonic-net#14439
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isabelladeleon12 isabelladeleon12

@qiluo-msft qiluo-msft

Labels
Triaged this issue has been triaged
Projects
None yet
Milestone
No milestone
4 participants
@zhangyanzhao @isabelladeleon12 @qiluo-msft @seanwu-ec