Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pfcwd not getting started as part of load_minigraph execution #9292

Closed
neethajohn opened this issue Nov 17, 2021 · 0 comments · Fixed by sonic-net/sonic-utilities#1937
Closed

Comments

@neethajohn
Copy link
Contributor

Description

As part of load_minigraph execution, pfcwd should get started on all device types excluding a few based on the below code
https://github.com/Azure/sonic-utilities/blob/master/config/main.py#L1521
But don't see it started

Steps to reproduce the issue:

  1. On a 202012 image, issue "config load_minigraph -y"
  2. Check if pfcwd is started using "pfcwd show config" and the output should list the ports on which pfcwd is started instead of empty list

Describe the results you received:

admin@sonic:~$ pfcwd show config
  PORT    ACTION    DETECTION TIME    RESTORATION TIME
------  --------  ----------------  ------------------

Describe the results you expected:

admin@sonic:~$ pfcwd show config
Changed polling interval to 200ms
       PORT    ACTION    DETECTION TIME    RESTORATION TIME
-----------  --------  ----------------  ------------------
  Ethernet4      drop               200                 200
  Ethernet8      drop               200                 200
 Ethernet12      drop               200                 200
 Ethernet16      drop               200                 200
 Ethernet20      drop               200                 200
 Ethernet24      drop               200                 200
 Ethernet28      drop               200                 200
 Ethernet32      drop               200                 200
 Ethernet36      drop               200                 200
 Ethernet40      drop               200                 200
 Ethernet44      drop               200                 200
 Ethernet48      drop               200                 200
 Ethernet52      drop               200                 200
 Ethernet56      drop               200                 200
 Ethernet60      drop               200                 200
 Ethernet64      drop               200                 200
 Ethernet68      drop               200                 200
 Ethernet72      drop               200                 200
 Ethernet76      drop               200                 200
 Ethernet80      drop               200                 200
 Ethernet84      drop               200                 200
 Ethernet88      drop               200                 200
 Ethernet92      drop               200                 200
 Ethernet96      drop               200                 200
Ethernet112      drop               200                 200
Ethernet116      drop               200                 200
Ethernet120      drop               200                 200
Ethernet124      drop               200                 200

Output of show version:

SONiC Software Version: SONiC.20201231.42
Distribution: Debian 10.11
Kernel: 4.19.0-12-2-amd64
Build commit: e13c354904
Build date: Mon Nov 15 16:05:23 UTC 2021
Built by: cloudtest@fd147d04c000000

Platform: x86_64-cel_seastone-r0
HwSKU: Celestica-DX010-C32
ASIC: broadcom
ASIC Count: 1
Serial Number: DX010F2B118711MS100008
Uptime: 21:15:49 up 23 min,  1 user,  load average: 1.15, 1.15, 0.98

Docker images:
REPOSITORY                 TAG                 IMAGE ID            SIZE
docker-syncd-brcm          20201231.42         1546e51fdae2        672MB
docker-syncd-brcm          latest              1546e51fdae2        672MB
docker-teamd               20201231.42         d9a99733da37        390MB
docker-teamd               latest              d9a99733da37        390MB
docker-router-advertiser   20201231.42         664530c2fce5        380MB
docker-router-advertiser   latest              664530c2fce5        380MB
docker-platform-monitor    20201231.42         8588f6e3e1ed        561MB
docker-platform-monitor    latest              8588f6e3e1ed        561MB
docker-lldp                20201231.42         b75d14700a7d        420MB
docker-lldp                latest              b75d14700a7d        420MB
docker-snmp                20201231.42         da4c922cc433        422MB
docker-snmp                latest              da4c922cc433        422MB
docker-dhcp-relay          20201231.42         e096bcbe787b        393MB
docker-dhcp-relay          latest              e096bcbe787b        393MB
docker-database            20201231.42         8820674ccb80        379MB
docker-database            latest              8820674ccb80        379MB
docker-orchagent           20201231.42         0220896f86fa        408MB
docker-orchagent           latest              0220896f86fa        408MB
docker-sonic-telemetry     20201231.42         74c76a591d9e        469MB
docker-sonic-telemetry     latest              74c76a591d9e        469MB
docker-mux                 20201231.42         bcc09c5fdcb5        432MB
docker-mux                 latest              bcc09c5fdcb5        432MB
docker-fpm-frr             20201231.42         ed39c9bdcc79        408MB
docker-fpm-frr             latest              ed39c9bdcc79        408MB
docker-sonic-restapi       20201231.42         3c1a676f843f        345MB
docker-sonic-restapi       latest              3c1a676f843f        345MB
docker-acms                20201231.42         c66e5dc2ae52        181MB
docker-acms                latest              c66e5dc2ae52        181MB
k8s.gcr.io/pause           3.4.1               0f8457a4c2ec        683kB

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):

@neethajohn neethajohn self-assigned this Nov 17, 2021
neethajohn added a commit to sonic-net/sonic-utilities that referenced this issue Nov 24, 2021
…dered (#1937)

Signed-off-by: Neetha John <nejo@microsoft.com>

Fixes sonic-net/sonic-buildimage#9292

What I did
Pfcwd was not getting started after executing load_minigraph after the changes done in #1508. This was because the PORT_QOS_MAP table is not yet present in config db (this gets populated only after the buffer templates are rendered) at the time we try to start pfcwd and hence the 'pfc_enable' field will always be empty and we skip writing PFC_WD table entries to config db.

How I did it
Delay pfcwd start until the buffer templates are rendered

How to verify it
Issue "config load_minigraph" with the changes and ensure that pfcwd is started on all active ports
qiluo-msft pushed a commit to sonic-net/sonic-utilities that referenced this issue Nov 30, 2021
…dered (#1937)

Signed-off-by: Neetha John <nejo@microsoft.com>

Fixes sonic-net/sonic-buildimage#9292

What I did
Pfcwd was not getting started after executing load_minigraph after the changes done in #1508. This was because the PORT_QOS_MAP table is not yet present in config db (this gets populated only after the buffer templates are rendered) at the time we try to start pfcwd and hence the 'pfc_enable' field will always be empty and we skip writing PFC_WD table entries to config db.

How I did it
Delay pfcwd start until the buffer templates are rendered

How to verify it
Issue "config load_minigraph" with the changes and ensure that pfcwd is started on all active ports
abdosi pushed a commit to sonic-net/sonic-utilities that referenced this issue Dec 8, 2021
…dered (#1937)

Signed-off-by: Neetha John <nejo@microsoft.com>

Fixes sonic-net/sonic-buildimage#9292

What I did
Pfcwd was not getting started after executing load_minigraph after the changes done in #1508. This was because the PORT_QOS_MAP table is not yet present in config db (this gets populated only after the buffer templates are rendered) at the time we try to start pfcwd and hence the 'pfc_enable' field will always be empty and we skip writing PFC_WD table entries to config db.

How I did it
Delay pfcwd start until the buffer templates are rendered

How to verify it
Issue "config load_minigraph" with the changes and ensure that pfcwd is started on all active ports
malletvapid23 added a commit to malletvapid23/Sonic-Utility that referenced this issue Aug 3, 2023
…dered (#1937)

Signed-off-by: Neetha John <nejo@microsoft.com>

Fixes sonic-net/sonic-buildimage#9292

What I did
Pfcwd was not getting started after executing load_minigraph after the changes done in #1508. This was because the PORT_QOS_MAP table is not yet present in config db (this gets populated only after the buffer templates are rendered) at the time we try to start pfcwd and hence the 'pfc_enable' field will always be empty and we skip writing PFC_WD table entries to config db.

How I did it
Delay pfcwd start until the buffer templates are rendered

How to verify it
Issue "config load_minigraph" with the changes and ensure that pfcwd is started on all active ports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant