Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Portconfig.ini parser in different applications are expecting different schema #992

Closed
taoyl-ms opened this issue Sep 27, 2017 · 4 comments
Closed

Portconfig.ini parser in different applications are expecting different schema #992

taoyl-ms opened this issue Sep 27, 2017 · 4 comments
Labels
Enhancement ➕ Question ❓

Comments

@taoyl-ms
Copy link
Contributor

Currently multiple applications are parsing portconfig.ini independently, and each of them are expecting a different schema. For example, some of them support port speed and/or port index fields while some do not.

We'll need unify the schema for that file and create a single parse to read from that file.
@jleveque
Copy link
Contributor

We also need to enforce a consistent name for the port index column. Some files call it index (e.g., https://github.com/Azure/sonic-buildimage/blob/master/device/dell/x86_64-dell_s6100_c2538-r0/Force10-S6100/port_config.ini), while others call it port (e.g., https://github.com/Azure/sonic-buildimage/blob/master/device/arista/x86_64-arista_7260cx3_64/Arista-7260CX3-C64/port_config.ini).

@jleveque
Copy link
Contributor

jleveque commented Sep 29, 2017 •
edited
Loading

Consistent naming convention for column header titles addressed here: #1001. Still need to create a single parser library per language.

@jleveque
Copy link
Contributor

Related to #496

@jleveque
Copy link
Contributor

Resolved with #1072

zhenggen-xu added a commit to zhenggen-xu/sonic-buildimage that referenced this issue Aug 2, 2019
@zhenggen-xu
Update sonic-swss submodule
aa0b243 
* src/sonic-swss 63afbd5...5be3963 (11):
  > Remove the platform check for remove/add port action at init phase. (sonic-net#1006)
  > [test]: Add Class object in each test script file (sonic-net#992)
  > [vstest]: add --imgname option to specify vs image to test (sonic-net#996)
  > [qosorch]: Add cir and pir parameters for scheduler (sonic-net#991)
  > [vstest]: report error when team kernel module is not available (sonic-net#994)
  > Support per buffer pool watermark polling mode (sonic-net#973)
  > [test]: Update test_vlan to use dvs functions (sonic-net#986)
  > Add synchronous switch to orch agent (sonic-net#987)
  > ARM32 bit fixes, for 64bit printf format specifier (sonic-net#989)
  > [portsorch]: Rename function isPortReady() to allPortsReady() (sonic-net#990)
  > [routeorch]: Fix observer detaching procedure for next hop observers (sonic-net#985)

Signed-off-by: Zhenggen Xu <zxu@linkedin.com>
lguohan pushed a commit that referenced this issue Aug 7, 2019
@zhenggen-xu @lguohan
[Feature: DynamicPortBreakout] Use consolidated bcm file for Seastone…
6f40933 
… platform (#3240)

* Utilize the same sai.profile and config.bcm file

Signed-off-by: Zhenggen Xu <zxu@linkedin.com>

* Fix the index issues for HWSKU: Seastone-DX010-25-50 and Seastone-DX010-50-40

Signed-off-by: Zhenggen Xu <zxu@linkedin.com>

* Update sonic-swss submodule

* src/sonic-swss 63afbd5...5be3963 (11):
  > Remove the platform check for remove/add port action at init phase. (#1006)
  > [test]: Add Class object in each test script file (#992)
  > [vstest]: add --imgname option to specify vs image to test (#996)
  > [qosorch]: Add cir and pir parameters for scheduler (#991)
  > [vstest]: report error when team kernel module is not available (#994)
  > Support per buffer pool watermark polling mode (#973)
  > [test]: Update test_vlan to use dvs functions (#986)
  > Add synchronous switch to orch agent (#987)
  > ARM32 bit fixes, for 64bit printf format specifier (#989)
  > [portsorch]: Rename function isPortReady() to allPortsReady() (#990)
  > [routeorch]: Fix observer detaching procedure for next hop observers (#985)

Signed-off-by: Zhenggen Xu <zxu@linkedin.com>
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this issue Mar 23, 2020
@stcheng
[test]: Add Class object in each test script file (sonic-net#992)
7368527 
This is to get a better JUnitXML file and align all
the tests under the same level of hierarchy.

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
@jleveque jleveque mentioned this issue Jul 23, 2020
Merged
lguohan pushed a commit that referenced this issue Jul 23, 2020
@jleveque
[sonic-utilities] Update submodule (#5023)
639ad18 
* src/sonic-utilities 82dfe50...995cf39 (1):
  > [config] Restart telemetry service upon config (re)load (#992)
lguohan added a commit that referenced this issue Aug 6, 2020
@lguohan
[submodule]: update sonic-utilities
544aa23 
ef0b1fa 2020-07-21 | [config] Restart telemetry service upon config (re)load (#992)

Signed-off-by: Guohan Lu <lguohan@gmail.com>
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this issue May 10, 2021
@jleveque
[config] Restart telemetry service upon config (re)load (sonic-net#992)
995cf39 
Add telemetry service to the list of services to stop/reset-failed/restart during config load/reload operations.
prsunny pushed a commit that referenced this issue Jan 21, 2022
@shi-su
Update sairedis submodule (#9819)
c30f667 
Commits:

02dea43 [202012] Add support for BFD notification (#990)
337fd97 Change sonic-buildimage.vs artifact source from CI build to official build. (#992)
490f442 Support for cisco-8000 platform for sonic-sairedis/syncd (#823)
@Pterosaur Pterosaur mentioned this issue Feb 22, 2022
Merged
6 tasks
Pterosaur added a commit that referenced this issue Feb 23, 2022
@Pterosaur
[submodule]: Update sonic-sairedis (#10061)
937ffbd 
Signed-off-by: Ze Gan <ganze718@gmail.com>

b9337dc (HEAD, origin/master, origin/HEAD) [vslib]: Fix MACsec bug in SCI and XPN (#1003)
edbceb9 [syncd][vslib] Keep new warm boot discovered SERDES objects (#985)
af5c156 Fix build issues on gcc-10 (#999)
1445cd5 update SAI submoule (#1001)
48fe704 [ci] pipeline fixes for VS test (#1002)
f484cf9 Enable SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL attribute (#975)
5d0b22d Enable SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL attribute (#975)
1b8ce97 (origin/202111) [pipeline] Download swss common artifact in a separated directory (#995)
7a2e096 Change sonic-buildimage.vs artifact source from CI build to official build. (#992)
judyjoseph added a commit that referenced this issue Feb 28, 2022
@judyjoseph
update sonic-sairedis
c6774ad 
5331ecd [vslib]: Fix MACsec bug in SCI and XPN (#1003)
ac04509 Fix build issues on gcc-10 (#999)
1b8ce97 [pipeline] Download swss common artifact in a separated directory (#995)
7a2e096 Change sonic-buildimage.vs artifact source from CI build to official build. (#992)
d5866a3 [vslib]: fix create MACsec SA error (#986)
f36f7ce Added Support for enum query capability of Nexthop Group Type. (#989)
323b89b Support for MACsec statistics (#892)
26a8a12 Prevent other notification event storms to keep enqueue unchecked and drained all memory that leads to crashing the switch router (#968)
0cb253a Fix object availability conversion (#974)
AidanCopeland pushed a commit to Metaswitch/sonic-buildimage that referenced this issue Apr 14, 2022
@liushilongbuaa
Change sonic-buildimage.vs artifact source from CI build to official …
7a2e096 
…build. (sonic-net#992)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement ➕ Question ❓
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stcheng @jleveque @taoyl-ms