[auto-ts] add memory check #10433
[auto-ts] add memory check #10433
Conversation
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@qiluo-msft could you please help to review or suggest someone who should? This is a feature for 202205 |
|
@stepanblyschak could you please update your PR to the latest so we can ensure build failures are behind us? |
|
@liat-grozovik It makes sense to run the checks after the dependency PR is merged and utilities submodule is updated |
| description "Minimum Free memory (in MB) that should be available for the techsupport execution to start"; | ||
| type uint32; | ||
| default 200; | ||
| } |
There was a problem hiding this comment.
Can you add unit test for these two new fields?
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@ganglyu @liat-grozovik Could you please help to merge? |
#### Why I did it To support automatic techsupport invokation in case memory usage is too high. #### How I did it Implemented according to sonic-net/SONiC#939 #### How to verify it UT, manual test on the switch. *DEPENDS* on sonic-net/sonic-utilities#2116
|
@stepanblyschak I've reverted this change in 202205 branch because it is causing test failure. Is this a feature or bug fix? Why do we need it in 202205 branch? |
|
@yxieca Which test is failing? I see that the following dependency PR hasn't yet in buildimage sonic-net/sonic-utilities#2413. This is a feature which was planned for 202205 but hasn't been backported in time. First submodule update: #12281 |
#### Why I did it To support automatic techsupport invokation in case memory usage is too high. #### How I did it Implemented according to sonic-net/SONiC#939 #### How to verify it UT, manual test on the switch. *DEPENDS* on sonic-net/sonic-utilities#2116
#### Why I did it To support automatic techsupport invokation in case memory usage is too high. #### How I did it Implemented according to sonic-net/SONiC#939 #### How to verify it UT, manual test on the switch. *DEPENDS* on sonic-net/sonic-utilities#2116
Why I did it
To support automatic techsupport invokation in case memory usage is too high.
How I did it
Implemented according to sonic-net/SONiC#939
How to verify it
UT, manual test on the switch.
DEPENDS on sonic-net/sonic-utilities#2116
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)