Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YANG] Update YANG model for pfcwd_sw_enable #10444

Merged
merged 3 commits into from
Apr 4, 2022
Merged

[YANG] Update YANG model for pfcwd_sw_enable #10444

merged 3 commits into from
Apr 4, 2022

Conversation

bingwang-ms
Copy link
Contributor

@bingwang-ms bingwang-ms commented Apr 2, 2022 •
edited
Loading

Signed-off-by: bingwang wang.bing@microsoft.com

Why I did it

This PR is to update YANG model sonic-port-qos-map.yang to support new table pfcwd_sw_enable.
HLD sonic-net/SONiC#950
Related PR #10176

How I did it

Update pfcwd_sw_enable.

How to verify it

Verified by UT

collected 3 items                                                                                                                                                                                     

tests/test_sonic_yang_models.py ..                                                                                                                                                              [ 66%]
tests/yang_model_tests/test_yang_model.py .                                                                                                                                                     [100%]

========================================================================================== 3 passed in 2.62s ==========================================================================================

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Update YANG model sonic-port-qos-map.yang to support new table pfcwd_sw_enable.

Link to config_db schema for YANG module changes

https://github.com/Azure/SONiC/wiki/Configuration#port-qos-map

A picture of a cute animal (not mandatory but encouraged)

@bingwang-ms
Update YANG for pfcwd_sw_enable
dead0c0 
Signed-off-by: bingwang <wang.bing@microsoft.com>
@bingwang-ms
Fix alignment
18b9884 
Signed-off-by: bingwang <wang.bing@microsoft.com>
@bingwang-ms bingwang-ms requested a review from wen587 April 2, 2022 04:27
@wen587
Copy link
Contributor

wen587 commented Apr 2, 2022

LGTM.

wen587
wen587 previously approved these changes Apr 2, 2022
View reviewed changes
@bingwang-ms bingwang-ms mentioned this pull request Apr 2, 2022
Merged
6 tasks
wen587
wen587 reviewed Apr 2, 2022
View reviewed changes
src/sonic-yang-models/yang-models/sonic-port-qos-map.yang
@@ -81,6 +81,12 @@ module sonic-port-qos-map {
}
}

leaf pfcwd_sw_enable {
type string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add description?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added. Thanks

@bingwang-ms
Add description
8704198 
Signed-off-by: bingwang <wang.bing@microsoft.com>
@bingwang-ms bingwang-ms merged commit 470d735 into sonic-net:master Apr 4, 2022
@bingwang-ms bingwang-ms mentioned this pull request Jun 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wen587 wen587 wen587 approved these changes

@qiluo-msft qiluo-msft qiluo-msft approved these changes

@praveen-li praveen-li Awaiting requested review from praveen-li

@venkatmahalingam venkatmahalingam Awaiting requested review from venkatmahalingam

@dgsudharsan dgsudharsan Awaiting requested review from dgsudharsan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bingwang-ms @wen587 @qiluo-msft @yxieca