Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Submodule] Update src/sonic-py-swsssdk #10996

Merged
merged 1 commit into from
Jun 24, 2022
Merged

[Submodule] Update src/sonic-py-swsssdk #10996

merged 1 commit into from
Jun 24, 2022

Conversation

liuh-80
Copy link
Contributor

@liuh-80 liuh-80 commented Jun 1, 2022 •
edited
Loading

Updating sonic-utilities sub module with the following commits

ca785a2 Remove sonic-db-cli

Why I did it

To fix sonic-db-cli high CPU usage on SONiC startup issue: #10218
sonic-db-cli re-write with c++ and move to sonic-swss-common repo.

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

ca785a2 Remove sonic-db-cli

A picture of a cute animal (not mandatory but encouraged)

@liuh-80 liuh-80 requested a review from lguohan as a code owner June 1, 2022 01:56
@liuh-80 liuh-80 requested a review from qiluo-msft June 1, 2022 01:57
@qiluo-msft
Copy link
Collaborator

qiluo-msft commented Jun 1, 2022 •
edited
Loading

This is a disruptive change. If we found it bad in case in future, we need to revert the commit on submodule, and move submodule.

@liuh-80
Copy link
Contributor Author

liuh-80 commented Jun 2, 2022

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lguohan
Copy link
Collaborator

lguohan commented Jun 2, 2022

can you provide motiviation, what is the benefit of switching to sonic-db-cli c++ implementation, how much gain are we seeing here?

@liuh-80
Copy link
Contributor Author

liuh-80 commented Jun 5, 2022 •
edited
Loading

can you provide motiviation, what is the benefit of switching to sonic-db-cli c++ implementation, how much gain are we seeing here?

This change is for following issue:
"sonic-db-cli high CPU usage on SONiC startup"
#10218

@liuh-80
Copy link
Contributor Author

liuh-80 commented Jun 5, 2022

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@qiluo-msft
Copy link
Collaborator

Please check the test failure

host = <MultiAsicSonicHost vlab-01>
cmd = "sonic-db-cli   APPL_DB HGETALL 'MACSEC_PORT_TABLE:Ethernet8'"

    def sonic_db_cli(host, cmd):
>       return ast.literal_eval(host.shell(cmd)["stdout_lines"][0])
E       IndexError: list index out of range

cmd        = "sonic-db-cli   APPL_DB HGETALL 'MACSEC_PORT_TABLE:Ethernet8'"
host       = <MultiAsicSonicHost vlab-01>

@liuh-80
Copy link
Contributor Author

liuh-80 commented Jun 8, 2022

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80
Copy link
Contributor Author

liuh-80 commented Jun 8, 2022 •
edited
Loading

Please check the test failure

host = <MultiAsicSonicHost vlab-01>
cmd = "sonic-db-cli   APPL_DB HGETALL 'MACSEC_PORT_TABLE:Ethernet8'"

    def sonic_db_cli(host, cmd):
>       return ast.literal_eval(host.shell(cmd)["stdout_lines"][0])
E       IndexError: list index out of range

cmd        = "sonic-db-cli   APPL_DB HGETALL 'MACSEC_PORT_TABLE:Ethernet8'"
host       = <MultiAsicSonicHost vlab-01>

Download image from pipeline and test on devbox passed will continue check reason.

After update UT code, can reproduce issue, UT failed with some recent UT change, will fix and update later.

@liushilongbuaa
Copy link
Contributor

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80
Copy link
Contributor Author

liuh-80 commented Jun 13, 2022

This PR blocked by a bug in new sonic-db-cli when handle hget commands, will create another PR to fix it.

@liuh-80
Copy link
Contributor Author

liuh-80 commented Jun 24, 2022

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80 liuh-80 merged commit 0c5b1b2 into sonic-net:master Jun 24, 2022
liuh-80 added a commit to liuh-80/sonic-buildimage that referenced this pull request Jun 27, 2022
@liuh-80
Update swsssdk submodule (sonic-net#10996)
b1fe54a 
Updating sonic-utilities sub module with the following commits

ca785a2 Remove sonic-db-cli

To fix sonic-db-cli high CPU usage on SONiC startup issue: sonic-net#10218
sonic-db-cli re-write with c++ and move to sonic-swss-common repo.

ca785a2 Remove sonic-db-cli

Co-authored-by: liuh-80 <azureuser@liuh-dev-vm-02.5fg3zjdzj2xezlx1yazx5oxkzd.hx.internal.cloudapp.net>
This was referenced Jun 27, 2022
Closed
Merged
liuh-80 added a commit that referenced this pull request Jun 29, 2022
@liuh-80
Revert sonic-db-cli change (#11282)
17cd7ba 
#### Why I did it
Revert PR '[Submodule] Update src/sonic-py-swsssdk #10996' which break UT in sonic-swss and sonic-swss-common

#### How I did it

#### How to verify it

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 201811
- [ ] 201911
- [ ] 202006
- [ ] 202012
- [ ] 202106
- [ ] 202111
- [ ] 202205

#### Description for the changelog
Revert PR '[Submodule] Update src/sonic-py-swsssdk #10996'


#### Link to config_db schema for YANG module changes


#### A picture of a cute animal (not mandatory but encouraged)
@liuh-80 liuh-80 mentioned this pull request Jul 8, 2022
Merged
@liuh-80 liuh-80 mentioned this pull request Aug 1, 2022
Closed
@liuh-80 liuh-80 added Request for 202111 Branch For PRs being requested for 202111 branch Request for 202205 Branch labels Aug 1, 2022
yxieca pushed a commit that referenced this pull request Aug 8, 2022
@liuh-80 @yxieca
Update swsssdk submodule (#10996)
f6ed142 
Updating sonic-utilities sub module with the following commits

ca785a2 Remove sonic-db-cli

#### Why I did it
To fix sonic-db-cli high CPU usage on SONiC startup issue: #10218
sonic-db-cli re-write with c++ and move to sonic-swss-common repo.

#### How I did it

#### How to verify it

#### Which release branch to backport (provide reason below if selected)

#### Description for the changelog
ca785a2 Remove sonic-db-cli

#### A picture of a cute animal (not mandatory but encouraged)


Co-authored-by: liuh-80 <azureuser@liuh-dev-vm-02.5fg3zjdzj2xezlx1yazx5oxkzd.hx.internal.cloudapp.net>
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Aug 9, 2022
@yxieca
Revert "Update swsssdk submodule (sonic-net#10996)"
7686b25 
This reverts commit f6ed142.
yxieca added a commit that referenced this pull request Aug 9, 2022
@yxieca
Revert "Update swsssdk submodule (#10996)"
5970a06 
This reverts commit f6ed142.
@yxieca
Copy link
Contributor

yxieca commented Aug 9, 2022

Reverted from 202205 branch due to PR test failures.

liuh-80 added a commit to liuh-80/sonic-buildimage that referenced this pull request Aug 12, 2022
@liuh-80
Update swsssdk submodule (sonic-net#10996)
5b09c35 
Updating sonic-utilities sub module with the following commits

ca785a2 Remove sonic-db-cli

#### Why I did it
To fix sonic-db-cli high CPU usage on SONiC startup issue: sonic-net#10218
sonic-db-cli re-write with c++ and move to sonic-swss-common repo.

#### How I did it

#### How to verify it

#### Which release branch to backport (provide reason below if selected)

#### Description for the changelog
ca785a2 Remove sonic-db-cli

#### A picture of a cute animal (not mandatory but encouraged)


Co-authored-by: liuh-80 <azureuser@liuh-dev-vm-02.5fg3zjdzj2xezlx1yazx5oxkzd.hx.internal.cloudapp.net>
@liuh-80 liuh-80 mentioned this pull request Aug 12, 2022
Merged
skbarista pushed a commit to skbarista/sonic-buildimage that referenced this pull request Aug 17, 2022
@liuh-80 @skbarista
Update swsssdk submodule (sonic-net#10996)
f52e144 
Updating sonic-utilities sub module with the following commits

ca785a2 Remove sonic-db-cli

#### Why I did it
To fix sonic-db-cli high CPU usage on SONiC startup issue: sonic-net#10218
sonic-db-cli re-write with c++ and move to sonic-swss-common repo.

#### How I did it

#### How to verify it

#### Which release branch to backport (provide reason below if selected)

#### Description for the changelog
ca785a2 Remove sonic-db-cli

#### A picture of a cute animal (not mandatory but encouraged)


Co-authored-by: liuh-80 <azureuser@liuh-dev-vm-02.5fg3zjdzj2xezlx1yazx5oxkzd.hx.internal.cloudapp.net>
skbarista pushed a commit to skbarista/sonic-buildimage that referenced this pull request Aug 17, 2022
@yxieca @skbarista
Revert "Update swsssdk submodule (sonic-net#10996)"
eb903f2 
This reverts commit f6ed142.
liuh-80 added a commit that referenced this pull request Aug 22, 2022
@liuh-80
Update swsssdk submodule (#10996) (#11714)
d9192b5 
Cherry pick PR ttps://github.com//pull/10996 to 202205 branch

Updating sonic-utilities sub module with the following commits

ca785a2 Remove sonic-db-cli

#### Why I did it
To fix sonic-db-cli high CPU usage on SONiC startup issue: #10218
sonic-db-cli re-write with c++ and move to sonic-swss-common repo.

#### How I did it

#### How to verify it

#### Which release branch to backport (provide reason below if selected)

#### Description for the changelog
ca785a2 Remove sonic-db-cli

#### A picture of a cute animal (not mandatory but encouraged)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiluo-msft qiluo-msft qiluo-msft approved these changes

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

Assignees
No one assigned
Labels
Request for 202111 Branch For PRs being requested for 202111 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liuh-80 @qiluo-msft @lguohan @liushilongbuaa @yxieca