Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IP interface loopback action related content to YANG models. #11012

Merged
merged 5 commits into from
Jun 20, 2022

Conversation

liorghub
Copy link
Contributor

@liorghub liorghub commented Jun 2, 2022

Why I did it

Add IP interface loopback action related content to the required YANG models.

How I did it

Update the relevant YANG models.

How to verify it

New unittests were added.

Which release branch to backport (provide reason below if selected)

  • 202205

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@liorghub
Copy link
Contributor Author

liorghub commented Jun 6, 2022

The following test is failing:
ERROR dhcp_relay/test_dhcp_relay.py::test_dhcp_relay_after_link_flap

@liorghub
Copy link
Contributor Author

liorghub commented Jun 6, 2022

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

dgsudharsan
dgsudharsan previously approved these changes Jun 6, 2022

leaf loopback_action {
description "Packet action when a packet ingress and gets routed on the same IP interface";
type stypes:loopback_action;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we specify the default action?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prsunny In general no. If we specify default action, this will be written to config_db. In case if the action is not implemented by other vendors there would be a SAI failure followed by orchagent crash.
So previously in yang subgroup we decided not to have default action for attributes that would be programmed into ASIC

@liorghub
Copy link
Contributor Author

The following test is failing:
ERROR bgp/test_bgp_fact.py::test_bgp_facts[128-vlab-02-None] - Failed

@liorghub
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liorghub
Copy link
Contributor Author

liorghub commented Jun 14, 2022

Build mellanox failed in apt command execution, trying another rerun.

2022-06-14T09:52:02.1711483Z �[0mThe command '/bin/sh -c apt-get update         &&     apt-get install -y                apt-utils                     build-essential               python3-dev' returned a non-zero code: 100
2022-06-14T09:52:02.1712946Z [  FAIL LOG END  ] [ target/docker-config-engine-bullseye.gz ]

@liorghub
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prsunny prsunny merged commit 467e005 into sonic-net:master Jun 20, 2022
yxieca pushed a commit that referenced this pull request Jun 22, 2022
)

*Add IP interface loopback action related content to the required YANG models.
skbarista pushed a commit to skbarista/sonic-buildimage that referenced this pull request Aug 17, 2022
…ic-net#11012)

*Add IP interface loopback action related content to the required YANG models.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants