-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IP interface loopback action related content to YANG models. #11012
Conversation
The following test is failing: |
/azpw run Azure.sonic-buildimage |
/AzurePipelines run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
This reverts commit 5ac5a5e.
|
||
leaf loopback_action { | ||
description "Packet action when a packet ingress and gets routed on the same IP interface"; | ||
type stypes:loopback_action; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we specify the default action?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prsunny In general no. If we specify default action, this will be written to config_db. In case if the action is not implemented by other vendors there would be a SAI failure followed by orchagent crash.
So previously in yang subgroup we decided not to have default action for attributes that would be programmed into ASIC
The following test is failing: |
/azpw run Azure.sonic-buildimage |
/AzurePipelines run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
Build mellanox failed in apt command execution, trying another rerun.
|
/azpw run Azure.sonic-buildimage |
/AzurePipelines run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
…ic-net#11012) *Add IP interface loopback action related content to the required YANG models.
Why I did it
Add IP interface loopback action related content to the required YANG models.
How I did it
Update the relevant YANG models.
How to verify it
New unittests were added.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)