Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support LOSSLESS_TRAFFIC_PATTERN and DEFAULT_LOSSLESS_BUFFER_PARAMETER #11058

Merged
merged 5 commits into from
Jun 23, 2022
Merged

Support LOSSLESS_TRAFFIC_PATTERN and DEFAULT_LOSSLESS_BUFFER_PARAMETER #11058

merged 5 commits into from
Jun 23, 2022

Conversation

stephenxs
Copy link
Collaborator

@stephenxs stephenxs commented Jun 7, 2022 •
edited
Loading

Why I did it

Support the following tables which were introduced during dynamic buffer calculation

  • LOSSLESS_TRAFFIC_PATTERN
  • DEFAULT_LOSSLESS_BUFFER_PARAMETER

Signed-off-by: Stephen Sun stephens@nvidia.com

How I did it

  • LOSSLESS_TRAFFIC_PATTERN
name type range mandatory description
mtu uint16 64~10240 true The maximum packet size of a lossless packet
small_packet_percentage uint8 0~100 true The percentage of small packet
  • DEFAULT_LOSSLESS_BUFFER_PARAMETER
name type range mandatory description
default_dynamic_th int8 -8~7 true The default dynamic_th for all buffer profiles that are dynamically generated for lossless PG
over_subscribe_ratio uint16 - false The oversubscribe ratio for shared headroom pool.
Semantically, the upper bound is the number of physical ports but it can not be represented in the yang module. So we keep the upper bound open. As the type is (signed) integer whose lower bound is 0 by nature, we do not need to specify the range.

How to verify it

Run unit test

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@stephenxs
Support LOSSLESS_TRAFFIC_PATTERN and DEFAULT_LOSSLESS_BUFFER_PARAMETER
027b0fc 
Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs stephenxs force-pushed the buffer_lossless_parameter_yangmodule branch from 88f4d55 to 027b0fc Compare June 7, 2022 11:06
@stephenxs
Remove default value for mandatory fields
73d2d1c 
Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs
Copy link
Collaborator Author

/azpw run azure.sonic-buildimage

@stephenxs
Remove yang modules that were added by mistake
6bffbd8 
Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs
Align lossless MTU with port MTU
38f180b 
Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs
Use the smallest type that accommodate the range of value
50ce756 
Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs stephenxs marked this pull request as ready for review June 15, 2022 11:50
@dgsudharsan dgsudharsan added the YANG YANG model related changes label Jun 15, 2022
@dgsudharsan
Copy link
Collaborator

@zhangyanzhao Here is the PR for the LOSSLESS_TRAFFIC_PATTERN and DEFAULT_LOSSLESS_BUFFER_PARAMETER tables

@stephenxs
Copy link
Collaborator Author

warm reboot issue

2022-06-15T10:35:01.1130300Z                 self.__clearArpAndFdbTables()
2022-06-15T10:35:01.1130983Z                 self.__revertRebootOper(rebootOper)
2022-06-15T10:35:01.1132328Z             if len(self.rebootData['sadList']) > 1 and count != len(self.rebootData['sadList']):
2022-06-15T10:35:01.1133220Z                 time.sleep(TIME_BETWEEN_SUCCESSIVE_TEST_OPER)
2022-06-15T10:35:01.1134187Z             failed_list = [(testcase,failures) for testcase, failures in test_results.items() if len(failures) != 0]
2022-06-15T10:35:01.1135118Z         pytest_assert(len(failed_list) == 0,\
2022-06-15T10:35:01.1136647Z >           "Advanced-reboot failure. Failed test: {}, failure summary:\n{}".format(self.request.node.name, failed_list))
2022-06-15T10:35:01.1138339Z E       Failed: Advanced-reboot failure. Failed test: test_warm_reboot[vlab-01], failure summary:
2022-06-15T10:35:01.1139918Z E       [('test_warm_reboot[vlab-01]None', ['Exception caught while running advanced-reboot test on ptf'])]

@stephenxs
Copy link
Collaborator Author

/azpw run azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@qiluo-msft qiluo-msft merged commit e9fee86 into sonic-net:master Jun 23, 2022
@liat-grozovik
Copy link
Collaborator

@stephenxs is this needed for 202205? if so please update the PR descirption

@stephenxs stephenxs deleted the buffer_lossless_parameter_yangmodule branch June 24, 2022 00:02
@stephenxs
Copy link
Collaborator Author

@stephenxs is this needed for 202205? if so please update the PR descirption

Done

yxieca pushed a commit that referenced this pull request Jun 24, 2022
@stephenxs @yxieca
Support LOSSLESS_TRAFFIC_PATTERN and DEFAULT_LOSSLESS_BUFFER_PARAMETER (
71c2b40 
#11058)

#### Why I did it
Support the following tables which were introduced during dynamic buffer calculation
- LOSSLESS_TRAFFIC_PATTERN
- DEFAULT_LOSSLESS_BUFFER_PARAMETER

#### How I did it

- LOSSLESS_TRAFFIC_PATTERN

|name|type|range|mandatory|description|
|---|---|---|---|---|
|mtu|uint16|64~10240|true|The maximum packet size of a lossless packet|
|small_packet_percentage|uint8|0~100|true|The percentage of small packet|

- DEFAULT_LOSSLESS_BUFFER_PARAMETER

|name|type|range|mandatory|description|
|---|---|---|---|---|
|default_dynamic_th|int8|-8~7|true|The default dynamic_th for all buffer profiles that are dynamically generated for lossless PG|
|over_subscribe_ratio|uint16|-|false|The oversubscribe ratio for shared headroom pool.|
|||||Semantically, the upper bound is the number of physical ports but it can not be represented in the yang module. So we keep the upper bound open. As the type is (signed) integer whose lower bound is 0 by nature, we do not need to specify the range.|

#### How to verify it
Run unit test
skbarista pushed a commit to skbarista/sonic-buildimage that referenced this pull request Aug 17, 2022
@stephenxs @skbarista
Support LOSSLESS_TRAFFIC_PATTERN and DEFAULT_LOSSLESS_BUFFER_PARAMETER (
1b5a427 
sonic-net#11058)

#### Why I did it
Support the following tables which were introduced during dynamic buffer calculation
- LOSSLESS_TRAFFIC_PATTERN
- DEFAULT_LOSSLESS_BUFFER_PARAMETER

#### How I did it

- LOSSLESS_TRAFFIC_PATTERN

|name|type|range|mandatory|description|
|---|---|---|---|---|
|mtu|uint16|64~10240|true|The maximum packet size of a lossless packet|
|small_packet_percentage|uint8|0~100|true|The percentage of small packet|

- DEFAULT_LOSSLESS_BUFFER_PARAMETER

|name|type|range|mandatory|description|
|---|---|---|---|---|
|default_dynamic_th|int8|-8~7|true|The default dynamic_th for all buffer profiles that are dynamically generated for lossless PG|
|over_subscribe_ratio|uint16|-|false|The oversubscribe ratio for shared headroom pool.|
|||||Semantically, the upper bound is the number of physical ports but it can not be represented in the yang module. So we keep the upper bound open. As the type is (signed) integer whose lower bound is 0 by nature, we do not need to specify the range.|

#### How to verify it
Run unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgsudharsan dgsudharsan dgsudharsan approved these changes

@neethajohn neethajohn neethajohn approved these changes

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft qiluo-msft is a code owner

Assignees
No one assigned
Labels
Included in 202205 Branch Request for 202205 Branch YANG YANG model related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@stephenxs @dgsudharsan @mssonicbld @liat-grozovik @neethajohn @qiluo-msft @yxieca