Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minigraph] Support parse IPv6 in device_desc.xml #11095

Merged
merged 9 commits into from
Jun 28, 2022

Conversation

Blueve
Copy link
Contributor

@Blueve Blueve commented Jun 10, 2022

Why I did it

minigraph parser can parse initial configuration from a fragment of minigraph (device_desc.xml), however it can only get IPv4 address from it and due to some reason, if the device only has IPv6 management IP address, then the IPv4 address will be 0.0.0.0/0 which will cause config load_mgmt_config command fail

How I did it

  1. Avoid put 0.0.0.0/0 to mgmt config
  2. Put IPv6 mgmt IP information to mgmt config if possiable

How to verify it

  • UT

Which release branch to backport (provide reason below if selected)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@lgtm-com
Copy link

lgtm-com bot commented Jun 10, 2022

This pull request fixes 1 alert when merging e50c789 into 0b1ae9c - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@lgtm-com

This comment was marked as duplicate.

@lgtm-com

This comment was marked as duplicate.

@lgtm-com
Copy link

lgtm-com bot commented Jun 22, 2022

This pull request fixes 1 alert when merging 3dd201f into c1d0d2e - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Jun 22, 2022

This pull request fixes 1 alert when merging 1feee4d into c1d0d2e - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@Blueve Blueve marked this pull request as ready for review June 23, 2022 14:32
@Blueve Blueve requested a review from a team as a code owner June 23, 2022 14:32
@qiluo-msft qiluo-msft requested a review from ganglyu June 23, 2022 23:59
@lgtm-com
Copy link

lgtm-com bot commented Jun 24, 2022

This pull request fixes 1 alert when merging ecdefad into 4afe209 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@Blueve Blueve merged commit 542cc08 into sonic-net:master Jun 28, 2022
Blueve added a commit to Blueve/sonic-buildimage that referenced this pull request Jun 28, 2022
Blueve added a commit to Blueve/sonic-buildimage that referenced this pull request Jun 28, 2022
yxieca pushed a commit that referenced this pull request Jun 28, 2022
Signed-off-by: Jing Kan jika@microsoft.com
Blueve added a commit that referenced this pull request Jul 1, 2022
#11095) (#11273)

* [minigraph] Support parse IPv6 in device_desc.xml (#11095)

Signed-off-by: Jing Kan jika@microsoft.com
Blueve added a commit that referenced this pull request Jul 1, 2022
Blueve added a commit to Blueve/sonic-buildimage that referenced this pull request Jul 5, 2022
sonic-net#11095) (sonic-net#11273)

* [minigraph] Support parse IPv6 in device_desc.xml (sonic-net#11095)

Signed-off-by: Jing Kan jika@microsoft.com
@Blueve Blueve deleted the dev/jika/minigraph_v6_mgmt branch August 8, 2022 04:31
skbarista pushed a commit to skbarista/sonic-buildimage that referenced this pull request Aug 17, 2022
<ManagementAddress xmlns:a="Microsoft.Search.Autopilot.NetMux">
<a:IPPrefix>0.0.0.0/0</a:IPPrefix>
</ManagementAddress>
<ManagementAddressV6 xmlns:a="Microsoft.Search.Autopilot.NetMux">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ManagementAddressV6

Could you reformat this XML file?

<Hostname>switch-t0</Hostname>
<HwSku>Force10-S6000</HwSku>
<ClusterName>AAA00PrdStr00</ClusterName>
<ManagementAddress xmlns:a="Microsoft.Search.Autopilot.NetMux">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ManagementAddress

Could you create another test data with no ManagementAddress node at all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants