Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Add flag 'skip_xcvrd_cmis_mgr' to skip CMIS task on Mellanox platform #11120

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

keboliu
Copy link
Collaborator

@keboliu keboliu commented Jun 13, 2022

Signed-off-by: Kebo Liu kebol@nvidia.com

Why I did it

The community introduced a CMIS cable sub-task to the XCVRD daemon to take care of the CMIS cable initializing work, which is not required on the Mellanox platform due to the different ways of managing the CMIS cable. Detail info please check PR sonic-net/SONiC#971

How I did it

Set flag 'skip_xcvrd_cmis_mgr' to true in pmon_daemon_control.json for all the Mellanox platforms.

How to verify it

Check CMIS task is not started on Mellanox platforms.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Kebo Liu <kebol@nvidia.com>
@keboliu keboliu requested a review from a team as a code owner June 13, 2022 11:55
@keboliu keboliu requested a review from prgeor June 13, 2022 12:01
@liat-grozovik
Copy link
Collaborator

@keboliu is this fix required for 202205? if so, lets add the label.
@prgeor please review and signoff

@prgeor prgeor merged commit b2bc90e into sonic-net:master Jun 15, 2022
@keboliu
Copy link
Collaborator Author

keboliu commented Jun 16, 2022

@prgeor I would like to request this PR to be cherry-picked to 202205, but it will also require other relevant PRs to be cherry-picked, would you please tag other PR?

yxieca pushed a commit that referenced this pull request Jul 28, 2022
@keboliu keboliu deleted the skip_cmis_task branch August 4, 2022 03:23
skbarista pushed a commit to skbarista/sonic-buildimage that referenced this pull request Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants