[teamd] Stop teamd after stopping swss in fast-reboot #11210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepanblyschak
requested review from
qiluo-msft,
xumia and
lguohan
as code owners
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
stepanblyschak
force-pushed
the
stop-bgp-before-teamd
branch
from
050884b
to
93c5ac8
Compare
dprital
added
Request for 202111 Branch
liat-grozovik
approved these changes
Jun 23, 2022
liat-grozovik
requested review from
judyjoseph
and removed request for
lguohan and
xumia
|
@judyjoseph could you please help to review or suggest a reviewer? |
1 similar comment
|
@judyjoseph could you please help to review or suggest a reviewer? |
vaibhavhd
approved these changes
Jul 11, 2022
yxieca
pushed a commit
that referenced
this pull request
Jul 17, 2022
- Why I did it To optimize fast-reboot. Teamd can be stopped after bgp is stopped and after swss is stopped because the last LACP packet can be sent still since syncd is still running. Saves 15 sec on shutdown. - How I did it Defined in the manifest for teamd to be stopped after swss - How to verify it Run it on the switch. Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
skbarista
pushed a commit
to skbarista/sonic-buildimage
that referenced
this pull request
Aug 17, 2022
- Why I did it To optimize fast-reboot. Teamd can be stopped after bgp is stopped and after swss is stopped because the last LACP packet can be sent still since syncd is still running. Saves 15 sec on shutdown. - How I did it Defined in the manifest for teamd to be stopped after swss - How to verify it Run it on the switch. Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stepan Blyschak stepanb@nvidia.com
Why I did it
To optimize fast-reboot. Teamd can be stopped after bgp is stopped and after swss is stopped because the last LACP packet can be sent still since syncd is still running. Saves 15 sec on shutdown.
How I did it
Defined in the manifest for teamd to be stopped after swss
How to verify it
Run it on the switch.
Before;
After:
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)