Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yang] update TCP_FLAGS format in sonic-acl.yang #11270

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

wen587
Copy link
Contributor

@wen587 wen587 commented Jun 28, 2022

Why I did it

Fix #11224
TCP_FLAGS supports flags/mask pattern. Refs https://github.com/Azure/sonic-utilities/blob/master/acl_loader/main.py#L574

How I did it

Change the pattern.

How to verify it

Add unit test.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@wen587 wen587 requested a review from bingwang-ms June 28, 2022 02:43
@wen587 wen587 requested a review from qiluo-msft as a code owner June 28, 2022 02:43
@wen587 wen587 requested a review from bingwang-ms June 28, 2022 08:51
@wen587 wen587 merged commit 859b479 into sonic-net:master Jun 30, 2022
yxieca pushed a commit that referenced this pull request Jun 30, 2022
Why I did it
Fix #11224
TCP_FLAGS supports flags/mask pattern.

How I did it
Change the pattern.

How to verify it
Add unit test.
skbarista pushed a commit to skbarista/sonic-buildimage that referenced this pull request Aug 17, 2022
Why I did it
Fix sonic-net#11224
TCP_FLAGS supports flags/mask pattern.

How I did it
Change the pattern.

How to verify it
Add unit test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[yang] TCP_FLAGS pattern need update in sonic-acl.yang
3 participants