Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sai_mdio_access_clause22=1 in td3x2-a720dt-48s-flex.config.bcm #11303

Merged
merged 2 commits into from
Jul 27, 2022

Conversation

jiahua-wang
Copy link
Contributor

@jiahua-wang jiahua-wang commented Jun 30, 2022

Signed-off-by: Jiahua Wang jiahua.wang@broadcom.com

Why I did it

The sai switch api as of now only has "switch_mdio_read/switch_mdio_write" functions. SAI needs another configuration parameter to distinguish mdio access clause 22 from clause 45.

How I did it

Adding the new soc property "sai_mdio_access_clause22" will allow the mdio device using the mdio clause 22 access with the same sai switch api functions "switch_mdio_read/switch_mdio_write".

How to verify it

On a platform with mdio clause 22 device connected to broadcom NPU mdio bus, PAI/gearbox will only work with the new soc property "sai_mdio_access_clause22=1".

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Jiahua Wang <jiahua.wang@broadcom.com>
@jiahua-wang jiahua-wang requested a review from a team as a code owner June 30, 2022 22:24
@lguohan
Copy link
Collaborator

lguohan commented Jul 6, 2022

@jiahua-wang , can you check the build failure?

@jiahua-wang
Copy link
Contributor Author

I see that
[line 303] Error: sai_mdio_access_clause22 is not permitted
Is there a permitted list of soc property keyword? This is a new soc property. How do we add the new soc property to the list?

Signed-off-by: Jiahua Wang <jiahua.wang@broadcom.com>
@prgeor
Copy link
Contributor

prgeor commented Jul 15, 2022

@jiahua-wang can you update these descriptions in the PR?

Why I did it
How I did it
How to verify it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants