Add bgp_device_global yang model #11343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Jul 6, 2022
src/sonic-yang-models/tests/yang_model_tests/tests/bgp_device_global.json
Outdated
Show resolved
Hide resolved
|
Could you add HLD link in the PR description? |
PR link #11257 included. This has the description and changes which brought in the new table |
ganglyu
reviewed
Jul 21, 2022
src/sonic-yang-models/tests/yang_model_tests/tests_config/bgp_device_global.json
Show resolved
Hide resolved
|
Reviewed in YANG community |
praveen-li
approved these changes
Jul 21, 2022
|
@ganglyu Any more concern? |
ganglyu
approved these changes
Jul 27, 2022
|
This is not considered a bug fix. Why need it on 202012 branch? |
yxieca
pushed a commit
that referenced
this pull request
Jul 28, 2022
skbarista
pushed a commit
to skbarista/sonic-buildimage
that referenced
this pull request
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Needed a configDB table to hold global device-specific BGP configuration
This table was introduced as part of changes to make traffic-shift-away (TSA) state persistent - #11257
How I did it
Add a new yang file sonic-bgp-device-global.yang and new test files
How to verify it
Compile target/python-wheels/sonic_yang_mgmt-1.0-py3-none-any.whl and target/python-wheels/sonic_yang_models-1.0-py3-none-any.whl
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
https://github.com/Azure/sonic-buildimage/blob/6fd7eab250ac54e9fedb68fc5248fdef2ba0adf6/src/sonic-yang-models/doc/Configuration.md#bgp-device-global
A picture of a cute animal (not mandatory but encouraged)