Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Arista] Add missing configs for 720DT-48S #11362

Merged
merged 5 commits into from
Jul 20, 2022

Conversation

andywongarista
Copy link
Contributor

@andywongarista andywongarista commented Jul 6, 2022

Why I did it

Followup to #10656. This change adds the remaining configs for the 720DT-48S platform.

How I did it

Adds the following:

  • gearbox_config.json and other gearbox-related config files, to enable traffic on external PHY ports (Ethernet0-23)
  • sensors.conf
  • pcie.yaml
    Also add missing facts in platform.json

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@andywongarista andywongarista requested a review from a team as a code owner July 6, 2022 17:33
@lguohan lguohan requested a review from jimmyzhai July 6, 2022 18:08
Copy link
Contributor

@Blueve Blueve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @andywongarista, can you update the alias column with etpN naming (N start from 1) ?

https://github.com/andywongarista/sonic-buildimage/blob/master/device/arista/x86_64-arista_720dt_48s/Arista-720DT-48S/port_config.ini

@lguohan I think we need this back port to 202205?

@lguohan
Copy link
Collaborator

lguohan commented Jul 13, 2022

@Blueve, they can do it in another pr.

Copy link
Contributor

@Blueve Blueve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Andy, please update the port config ini in another PR

@Blueve Blueve self-requested a review July 14, 2022 01:12
@andywongarista
Copy link
Contributor Author

Hi Andy, please update the port config ini in another PR

Sure

@Blueve
Copy link
Contributor

Blueve commented Jul 18, 2022

@andywongarista @jimmyzhai are we good to merge this PR?

@andywongarista
Copy link
Contributor Author

@andywongarista @jimmyzhai are we good to merge this PR?

Yes

@Blueve Blueve merged commit 07dbc14 into sonic-net:master Jul 20, 2022
@yxieca
Copy link
Contributor

yxieca commented Jul 28, 2022

@andywongarista please raise separate PR for 202205 branch.

@Blueve
Copy link
Contributor

Blueve commented Aug 1, 2022

@andywongarista I installed image:

SONiC Software Version: SONiC.master.128992-cdd278611
Distribution: Debian 11.4
Kernel: 5.10.0-12-2-amd64
Build commit: cdd278611
Build date: Sun Jul 31 16:35:13 UTC 2022
Built by: AzDevOps@sonic-build-workers-001UZN

But show int status still not list any port. Do you have any suggestion?

andywongarista added a commit to andywongarista/sonic-buildimage that referenced this pull request Aug 30, 2022
* Why I did it
Followup to sonic-net#10656. This change adds the remaining configs for the 720DT-48S platform.

* How I did it
Adds the following:
gearbox_config.json and other gearbox-related config files, to enable traffic on external PHY ports (Ethernet0-23)
sensors.conf
pcie.yaml
Also add missing facts in platform.json

* How to verify it
show interfaces status shows links up on interfaces Ethernet0-23
traffic flows with no errors on interfaces Ethernet0-23
Note: above testing depends on Add gbsyncd container for broncos sonic-net#11154 and [orchagent]: Enhance initSaiPhyApi sonic-swss#2367, as well as having the appropriate PAI driver.

Co-authored-by: Samuel Angebault <staphylo@arista.com>
jimmyzhai pushed a commit that referenced this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants