[caclmgrd]: Add infrastructure to support adding feature specific acls #11367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ACLs if required. Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
SuvarnaMeenakshi
commented
Jul 8, 2022
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
qiluo-msft
reviewed
Jul 8, 2022
| @@ -201,6 +206,12 @@ class ControlPlaneAclManager(daemon_base.DaemonBase): | |||
| tcp_flags_str = tcp_flags_str[:-1] | |||
| return tcp_flags_str | |||
|
|
|||
| def update_feature_present(self): | |||
There was a problem hiding this comment.
Added unit-test and mock data for the unit-test.
qiluo-msft
reviewed
Jul 8, 2022
| feature_tb_info = self.config_db_map[DEFAULT_NAMESPACE].get_table(self.FEATURE_TABLE) | ||
| if feature_tb_info: | ||
| for k, v in feature_tb_info.items(): | ||
| self.feature_present[k] = True |
There was a problem hiding this comment.
Seems this is a generic oneshot cache. Suggest leverage common library like cached_property. ref: https://www.geeksforgeeks.org/python-functools-cached_property/ #WontFix
There was a problem hiding this comment.
thank you for the pointer. Currently, we are updating this feature_present map with the features that are present only once during initialization so it is not repeatedlyinvoked.
Also, if we use cached_property, we will invoke the function once, which could be in per-thread context, which might cause issues. So not using cached_property in this case.
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
qiluo-msft
approved these changes
Jul 13, 2022
yxieca
pushed a commit
that referenced
this pull request
Jul 17, 2022
#11367) Why I did it Add infrastructure to support adding feature specific acls. If feature specific ACLs has to be added: if feature_name in self.feature_present and self.feature_present.get('feature_name'): add_feature_specific_acls() How I did it Add function to get features present in feature table. How to verify it unit-test passes.
skbarista
pushed a commit
to skbarista/sonic-buildimage
that referenced
this pull request
Aug 17, 2022
sonic-net#11367) Why I did it Add infrastructure to support adding feature specific acls. If feature specific ACLs has to be added: if feature_name in self.feature_present and self.feature_present.get('feature_name'): add_feature_specific_acls() How I did it Add function to get features present in feature table. How to verify it unit-test passes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Suvarna Meenakshi sumeenak@microsoft.com
Why I did it
Add infrastructure to support adding feature specific acls.
If feature specific ACLs has to be added:
How I did it
Add function to get features present in feature table.
How to verify it
unit-test passes.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)