[docker-teamd]: Manage teamd and teamsyncd processes with supervisor #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stcheng
reviewed
Nov 10, 2017
| # the LAG and the path of the LAG config file. Then output this in | ||
| # JSON format, as we will pass it to sonic-cfggen as additional data | ||
| # below for generating the supervisord config file. | ||
| LAG_INFO_DICT=$(python -c "import json,os,sys; out_dict = {}; out_dict['lags'] = [{'name': os.path.basename(file).split('.')[0], 'file': os.path.join('${TEAMD_CONF_PATH}', file)} for file in os.listdir('${TEAMD_CONF_PATH}')]; sys.stdout.write(json.dumps(out_dict))") |
There was a problem hiding this comment.
Could you also provide a sample output here?
|
can you also add corresponding j2 tests? |
lguohan
reviewed
Nov 10, 2017
…test; also sort in docker-teamd-init.sh script to keep behavior similar between actual script and unit test
lguohan
approved these changes
Nov 13, 2017
stcheng
pushed a commit
that referenced
this pull request
Nov 16, 2017
…ervisor (#1137)" (#1156) This reverts commit a6edef2. The reason to revert this commit is that it breaks the current nightly test as no port channel interfaces are get created after boot. teamd failed to start and complained about 'Cannot allocate memory' possibly due to nlmsg_alloc function failure. Will revert this commit to investigate it further before moving to supervisor. Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
abdosi
added a commit
that referenced
this pull request
Sep 29, 2020
[cli][bgp]use vtysh in the show ip bgp summary command (#1137) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
lguohan
pushed a commit
that referenced
this pull request
Oct 6, 2020
- [acl-loader] Revert fix for IP protocol == 0 (#1142) - Show sflow interface to display all interfaces enabled for sflow (#1143) - [sflow_test.py]: tests for config sflow commands. (#1112) - [config/console] Support add/del console port setting commands (#1136) - [cli][bgp]use vtysh in the show ip bgp summary command (#1137) - [README.md] Describe new package creation schema (#1131) - [consutil] Remove actual baud and refactor lib for future change (#1130) Signed-off-by: Danny Allen <daall@microsoft.com>
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…t#5545) - [acl-loader] Revert fix for IP protocol == 0 (sonic-net#1142) - Show sflow interface to display all interfaces enabled for sflow (sonic-net#1143) - [sflow_test.py]: tests for config sflow commands. (sonic-net#1112) - [config/console] Support add/del console port setting commands (sonic-net#1136) - [cli][bgp]use vtysh in the show ip bgp summary command (sonic-net#1137) - [README.md] Describe new package creation schema (sonic-net#1131) - [consutil] Remove actual baud and refactor lib for future change (sonic-net#1130) Signed-off-by: Danny Allen <daall@microsoft.com>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
May 10, 2021
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com> Modify the run_bgp_command function to call vtysh with correct instance_id and vtysh cmd. The vtysh script is modified to take the namespace id in this PR sonic-net#5479
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
systemctl start/stop teamd) and ensure all processes start/stop properly, and that teamd processes clean up after themselves properly.- A picture of a cute animal (not mandatory but encouraged)