Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202012] Update MMU and ECN settings for Arista-7260CX3-D96C16 #11427

Merged
merged 3 commits into from
Jul 15, 2022

Conversation

neethajohn
Copy link
Contributor

@neethajohn neethajohn commented Jul 12, 2022

Why I did it

Missed this sku in the previous PR #11398

How I did it

Update the dynamic threshold to 0 and ECN settings as 2mb/10mb/5%

How to verify it

Updated unit tests to use the modified values for 7260 ecn settings.

@neethajohn neethajohn marked this pull request as ready for review July 13, 2022 16:06
@neethajohn neethajohn requested a review from yxieca July 13, 2022 16:07
@yxieca
Copy link
Contributor

yxieca commented Jul 13, 2022

Should this be a master branch PR and cherry-pick back?

@neethajohn neethajohn changed the base branch from 202012 to master July 13, 2022 17:36
@neethajohn neethajohn changed the base branch from master to 202012 July 13, 2022 17:36
@neethajohn
Copy link
Contributor Author

Should this be a master branch PR and cherry-pick back?

Unit tests cannot be cleanly cherry picked. I will do a separate PR for master which most probably can be cherry picked to 202205

@neethajohn neethajohn marked this pull request as draft July 13, 2022 19:03
Signed-off-by: Neetha John <nejo@microsoft.com>
Signed-off-by: Neetha John <nejo@microsoft.com>
Signed-off-by: Neetha John <nejo@microsoft.com>
@neethajohn neethajohn marked this pull request as ready for review July 14, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants