Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for TSA error logging on multi-asic #11519

Merged
merged 4 commits into from
Jul 31, 2022
Merged

Fix for TSA error logging on multi-asic #11519

merged 4 commits into from
Jul 31, 2022

Conversation

tjchadaga
Copy link
Contributor

@tjchadaga tjchadaga commented Jul 23, 2022

Why I did it

TSA/TSB scripts check current state and report error if the state is already in Maintenance/Normal mode. This lookup was not done per DB instance

How I did it

Changed state lookup per DB instance

How to verify it

Execute TSA twice on multi-asic and check that the error message - "System already in Maintenance" is logged for each DB instance

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Link to config_db schema for YANG module changes

TSA/B script output on Multi-asic
log_and_err_message_output.txt

Copy link
Contributor

@judyjoseph judyjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Add the test logs/err messages to the PR description will be helpful

@tjchadaga
Copy link
Contributor Author

LGTM, Add the test logs/err messages to the PR description will be helpful

Updated

@tjchadaga tjchadaga merged commit cdd2786 into sonic-net:master Jul 31, 2022
@tjchadaga tjchadaga deleted the tsa_test_fixes branch July 31, 2022 05:17
yxieca pushed a commit that referenced this pull request Aug 1, 2022
@qiluo-msft
Copy link
Collaborator

This commit could not be cleanly cherry-picked to 202012. Please submit another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants