Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hlx/sfp] fix hlx platform sfp+ tx disable issue #11532

Merged
merged 1 commit into from
Jul 28, 2022
Merged

[hlx/sfp] fix hlx platform sfp+ tx disable issue #11532

merged 1 commit into from
Jul 28, 2022

Conversation

qnos
Copy link
Contributor

@qnos qnos commented Jul 26, 2022 •
edited by Blueve
Loading

Why I did it:
To fix hlx platform sfp+ module tx disable issue

How I did it:
Fix sfp+ tx disable function according SFF-8472 specification

Why I did it

To fix hlx platform sfp+ module tx disable issue.

How I did it

Fix sfp+ tx disable function according SFF-8472 specification.

How to verify it

import sonic_platform
platform = sonic_platform.platform.Platform()
sfp49 = platform._chassis.get_all_sfps()[48]
sfp49.tx_disable(True)
sfp49.get_tx_disable()
sfp49.tx_disable(False)
sfp49.get_tx_disable()

sfp50 = platform._chassis.get_all_sfps()[49]
sfp50.tx_disable(True)
sfp50.get_tx_disable()
sfp50.tx_disable(False)
sfp50.get_tx_disable()

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

@qnos
fix hlx platform sfp+ tx disable issue
a5a8f6b 
Why I did it:
To fix hlx platform sfp+ module tx disable issue

How I did it:
Fix sfp+ tx disable function according SFF-8472 specification
@qnos qnos requested a review from a team as a code owner July 26, 2022 05:14
@Blueve Blueve changed the title fix hlx platform sfp+ tx disable issue [hlx/sfp] fix hlx platform sfp+ tx disable issue Jul 28, 2022
@Blueve Blueve merged commit c9ae874 into sonic-net:master Jul 28, 2022
yxieca pushed a commit that referenced this pull request Jul 28, 2022
@qnos @yxieca
[hlx/sfp] fix hlx platform sfp+ tx disable issue (#11532)
400b401 
Why I did it:
To fix hlx platform sfp+ module tx disable issue

How I did it:
Fix sfp+ tx disable function according SFF-8472 specification

Co-authored-by: Eric Zhu <erzhu@celestica.com>
@prgeor
Copy link
Contributor

prgeor commented Jul 28, 2022

@qnos when is your platform planned to start using SFP-refactor?

@qnos
Copy link
Contributor Author

qnos commented Jul 29, 2022

@qnos when is your platform planned to start using SFP-refactor?

No plan yet. The refactor seems good, we will evaluate it.

qiluo-msft pushed a commit that referenced this pull request Aug 9, 2022
@qnos @qiluo-msft
[hlx/sfp] fix hlx platform sfp+ tx disable issue (#11532)
cf12aa5 
Why I did it:
To fix hlx platform sfp+ module tx disable issue

How I did it:
Fix sfp+ tx disable function according SFF-8472 specification

Co-authored-by: Eric Zhu <erzhu@celestica.com>
skbarista pushed a commit to skbarista/sonic-buildimage that referenced this pull request Aug 17, 2022
@qnos @skbarista
[hlx/sfp] fix hlx platform sfp+ tx disable issue (sonic-net#11532)
201ce34 
Why I did it:
To fix hlx platform sfp+ module tx disable issue

How I did it:
Fix sfp+ tx disable function according SFF-8472 specification

Co-authored-by: Eric Zhu <erzhu@celestica.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blueve Blueve Blueve approved these changes

Assignees
No one assigned
Labels
Included in 202012 Branch Included in 202205 Branch Platform: Celestica Request for 202012 Branch Request for 202106 Branch Request for 202205 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qnos @prgeor @Blueve @qiluo-msft @yxieca