Support different DSCP_TO_TC_MAP for T1 in dualtor deployment
#11569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neethajohn
reviewed
Jul 28, 2022
bingwang-ms
added
Request for 202205 Branch
and removed
Request for 202205 Branch
labels
neethajohn
approved these changes
Jul 29, 2022
7 tasks
neethajohn
pushed a commit
that referenced
this pull request
Aug 1, 2022
…nt (#11580) Why I did it This PR is to backport #11569 into 202012 branch. This PR is to apply different DSCP_TO_TC_MAP to downlink and uplink ports on T1 in dualtor deployment. For T1 downlink ports (To T0) The DSCP_TO_TC_MAP is not changed. DSCP2 and DSCP6 are mapped to TC2 and TC6 respectively. For T1 uplink ports (To T1) A new DSCP_TO_TC_MAP|AZURE_UPLINK is defined and applied. DSCP2 and DSCP6 are mapped to TC1 to avoid mixing up lossy and lossless traffic from T2. The extra lossy PG2 and PG6 added in PR #11157 is reverted as well because no traffic from T2 is mapped to PG2 or PG6 now. How I did it Define a new map DSCP_TO_TC_MAP|AZURE_UPLINK for 7260 T1. How to verify it Verified by test case in test_j2files.py.
yxieca
pushed a commit
that referenced
this pull request
Aug 8, 2022
* Support different DSCP_TO_TC_MAP for T1 in dualtor deployment
skbarista
pushed a commit
to skbarista/sonic-buildimage
that referenced
this pull request
Aug 17, 2022
…c-net#11569) * Support different DSCP_TO_TC_MAP for T1 in dualtor deployment
Merged
5 tasks
5 tasks
wangxin
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Nov 14, 2022
What is the motivation for this PR? This PR is to backport PR #6393 into 202012 branch. This PR is to add two new test cases testQosSaiSeparatedDscpQueueMapping and testQosSaiSeparatedDscpToPgMapping to verify separated DSCP_TO_TC_MAP for uplink and downlink on T1. Code change in sonic-buildimage sonic-net/sonic-buildimage#11569 How did you do it? Swap syncd docker to syncd-rpc Generate traffic with various DSCP value, and send the packet to DUT from uplink ports or downlink ports Check the increment in each PG and Queue with SAI rpc call. How did you verify/test it? Verified on a TH2 device ``` collected 2 items qos/test_qos_sai.py::TestQosSai::testQosSaiSeparatedDscpQueueMapping[str-7260cx3-acs-7-None-downstream] PASSED [ 50%] qos/test_qos_sai.py::TestQosSai::testQosSaiSeparatedDscpQueueMapping[str-7260cx3-acs-7-None-upstream] PASSED [100%] collected 2 items qos/test_qos_sai.py::TestQosSai::testQosSaiSeparatedDscpToPgMapping[str-7260cx3-acs-7-None-downstream] PASSED [ 50%] qos/test_qos_sai.py::TestQosSai::testQosSaiSeparatedDscpToPgMapping[str-7260cx3-acs-7-None-upstream] PASSED [100%] ``` Any platform specific information? No. Supported testbed topology if it's a new test case? T1 specific test cases.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
This PR is to apply different
DSCP_TO_TC_MAPto downlink and uplink ports on T1 in dualtor deployment.The
DSCP_TO_TC_MAPis not changed.DSCP2andDSCP6are mapped toTC2andTC6respectively.A new
DSCP_TO_TC_MAP|AZURE_UPLINKis defined and applied.DSCP2andDSCP6are mapped toTC1to avoid mixing up lossy and lossless traffic from T2.The extra lossy
PG2andPG6added in PR #11157 is reverted as well because no traffic from T2 is mapped toPG2orPG6now.How I did it
Define a new map
DSCP_TO_TC_MAP|AZURE_UPLINKfor 7260 T1.How to verify it
Verified by test case in
test_j2files.py.Which release branch to backport (provide reason below if selected)
Description for the changelog
Support different
DSCP_TO_TC_MAPfor T1 in dualtor deploymentLink to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)