Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mellanox] [SKU] Mellanox-SN4700-C128 SKU added #11574

Merged
merged 13 commits into from
Aug 11, 2022
Merged

[Mellanox] [SKU] Mellanox-SN4700-C128 SKU added #11574

merged 13 commits into from
Aug 11, 2022

Conversation

vivekrnv
Copy link
Contributor

@vivekrnv vivekrnv commented Jul 28, 2022 •
edited by liat-grozovik
Loading

Signed-off-by: Vivek Reddy Karri vkarri@nvidia.com

Why I did it

A new SKU for MSN-4700 Platform i.e. Mellanox-SN4700-C128

Requirements:

  • Breakout: Port 1-32: 4x100G
  • Downlinks: 120 (1-30)
  • Uplinks: 8 (31-32)
  • Shared Headroom: Enabled
  • Over Subscribe Ratio: 1:8
  • Default Topology: T2
  • Default Cable Length for T2: 1500m
  • QoS params: The default ones defined in qos_config.j2 will be applied
  • Small Packet Percentage: Used 50% for traditional buffer model Note: For dynamic model, the value defined in LOSSLESS_TRAFFIC_PATTERN|AZURE|small_packet_percentage is used
Additional Details:
  • Switch Type has to be programmed as SpineRouter through config_db.json in DEVICE_METADATA|localhost|type field for the buffer values & cable lengths defined in the buffers_defaults_t2.j2 to apply on the device
  • Cable Lengths Used for generating buffer_defaults_{t0,t1,t2}.j2 values
 {
        "t2": {
            "up": "1500m",
            "down": "1500m",       
         },
        "t1": {
            "up": "300m",
            "down": "40m",
        },
        "t0": {
            "up": "40m",
            "down": "5m",
        }
}

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

syslog.gz

@vivekrnv
SKU first draft added
7872b21 
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekrnv
Removev 200G,1500m tuple and added ports2cable dict in t2 defaults
193aa60 
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekrnv
Updated buffer_defaults and rounded off to nearest cell size multiple
dcbfc26 
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekrnv
Removed fec settings from the port_config.ini
2026d73 
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekrnv
Updated the copyright
fa67b5d 
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekrnv
Cell roundoff removed and updated mistakes in t0,t1 buffer defaults
ad1b4b3 
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekrnv
adjust sizes for mirroring
f27c1ee 
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekrnv
Merge branch 'master' of https://github.com/Azure/sonic-buildimage in…
0731d35 
…to sku_4700_c128
@vivekrnv
Updated port related config
63acd3e 
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekrnv
Minor Indent change
039c82a 
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekrnv
Merge branch 'master' of https://github.com/Azure/sonic-buildimage in…
54ed2df 
…to sku_4700_c128
@vivekrnv vivekrnv requested a review from a team as a code owner July 28, 2022 15:47
@vivekrnv
Copy link
Contributor Author

vivekrnv commented Aug 1, 2022

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@zhenggen-xu
Copy link
Collaborator

Can you please share the commit-id this PR was tested on? and also the syslog when you do "config reload" the configurations with Qos/buffer enabled on this HWSKU?

@vivekrnv
Copy link
Contributor Author

vivekrnv commented Aug 2, 2022 •
edited
Loading

Can you please share the commit-id this PR was tested on? and also the syslog when you do "config reload" the configurations with Qos/buffer enabled on this HWSKU?

This was tested on latest 202205. Will share the config reload logs by end of this week

@vivekrnv
Copy link
Contributor Author

vivekrnv commented Aug 5, 2022 •
edited
Loading

Can you please share the commit-id this PR was tested on? and also the syslog when you do "config reload" the configurations with Qos/buffer enabled on this HWSKU?

I've uploaded the syslog. config reload was run around 00:00:54

@vivekrnv
Copy link
Contributor Author

vivekrnv commented Aug 8, 2022

/easycla

@liat-grozovik liat-grozovik merged commit 15e59fc into sonic-net:master Aug 11, 2022
yxieca pushed a commit that referenced this pull request Aug 11, 2022
@vivekrnv @yxieca
[Mellanox] [SKU] Mellanox-SN4700-C128 SKU added (#11574)
adccd64 
- Why I did it
New SKU for MSN-4700 Platform i.e. Mellanox-SN4700-C128

Requirements:
* Breakout: Port 1-32: 4x100G
* Downlinks: 120 (1-30)
* Uplinks: 8 (31-32)
* Shared Headroom: Enabled
* Over Subscribe Ratio: 1:8
* Default Topology: T2
* Default Cable Length for T2: 1500m
* QoS params: The default ones defined in qos_config.j2 will be applied
* Small Packet Percentage: Used 50% for traditional buffer model Note: For dynamic model, the value defined in LOSSLESS_TRAFFIC_PATTERN|AZURE|small_packet_percentage is used

Additional Details:
Switch Type has to be programmed as SpineRouter through config_db.json in DEVICE_METADATA|localhost|type field for the buffer values & cable lengths defined in the buffers_defaults_t2.j2 to apply on the device
Cable Lengths Used for generating buffer_defaults_{t0,t1,t2}.j2 values

Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekrnv vivekrnv deleted the sku_4700_c128 branch August 15, 2022 04:09
skbarista pushed a commit to skbarista/sonic-buildimage that referenced this pull request Aug 17, 2022
@vivekrnv @skbarista
[Mellanox] [SKU] Mellanox-SN4700-C128 SKU added (sonic-net#11574)
4767319 
- Why I did it
New SKU for MSN-4700 Platform i.e. Mellanox-SN4700-C128

Requirements:
* Breakout: Port 1-32: 4x100G
* Downlinks: 120 (1-30)
* Uplinks: 8 (31-32)
* Shared Headroom: Enabled
* Over Subscribe Ratio: 1:8
* Default Topology: T2
* Default Cable Length for T2: 1500m
* QoS params: The default ones defined in qos_config.j2 will be applied
* Small Packet Percentage: Used 50% for traditional buffer model Note: For dynamic model, the value defined in LOSSLESS_TRAFFIC_PATTERN|AZURE|small_packet_percentage is used

Additional Details:
Switch Type has to be programmed as SpineRouter through config_db.json in DEVICE_METADATA|localhost|type field for the buffer values & cable lengths defined in the buffers_defaults_t2.j2 to apply on the device
Cable Lengths Used for generating buffer_defaults_{t0,t1,t2}.j2 values

Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
vivekrnv added a commit to vivekrnv/sonic-buildimage that referenced this pull request Aug 29, 2022
@vivekrnv
[Mellanox] [SKU] Mellanox-SN4700-C128 SKU added (sonic-net#11574)
74c82d5 
- Why I did it
New SKU for MSN-4700 Platform i.e. Mellanox-SN4700-C128

Requirements:
* Breakout: Port 1-32: 4x100G
* Downlinks: 120 (1-30)
* Uplinks: 8 (31-32)
* Shared Headroom: Enabled
* Over Subscribe Ratio: 1:8
* Default Topology: T2
* Default Cable Length for T2: 1500m
* QoS params: The default ones defined in qos_config.j2 will be applied
* Small Packet Percentage: Used 50% for traditional buffer model Note: For dynamic model, the value defined in LOSSLESS_TRAFFIC_PATTERN|AZURE|small_packet_percentage is used

Additional Details:
Switch Type has to be programmed as SpineRouter through config_db.json in DEVICE_METADATA|localhost|type field for the buffer values & cable lengths defined in the buffers_defaults_t2.j2 to apply on the device
Cable Lengths Used for generating buffer_defaults_{t0,t1,t2}.j2 values

Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekrnv vivekrnv mentioned this pull request Aug 29, 2022
Merged
7 tasks
vivekrnv added a commit to vivekrnv/sonic-buildimage that referenced this pull request Aug 30, 2022
@vivekrnv
[Mellanox] [SKU] Mellanox-SN4700-C128 SKU added (sonic-net#11574)
f526647 
- Why I did it
New SKU for MSN-4700 Platform i.e. Mellanox-SN4700-C128

Requirements:
* Breakout: Port 1-32: 4x100G
* Downlinks: 120 (1-30)
* Uplinks: 8 (31-32)
* Shared Headroom: Enabled
* Over Subscribe Ratio: 1:8
* Default Topology: T2
* Default Cable Length for T2: 1500m
* QoS params: The default ones defined in qos_config.j2 will be applied
* Small Packet Percentage: Used 50% for traditional buffer model Note: For dynamic model, the value defined in LOSSLESS_TRAFFIC_PATTERN|AZURE|small_packet_percentage is used

Additional Details:
Switch Type has to be programmed as SpineRouter through config_db.json in DEVICE_METADATA|localhost|type field for the buffer values & cable lengths defined in the buffers_defaults_t2.j2 to apply on the device
Cable Lengths Used for generating buffer_defaults_{t0,t1,t2}.j2 values

Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
vivekrnv added a commit to vivekrnv/sonic-buildimage that referenced this pull request Sep 6, 2022
@vivekrnv
Revert "[Mellanox] [SKU] Mellanox-SN4700-C128 SKU added (sonic-net#11574
8cf3291 
)"

This reverts commit 74c82d5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liat-grozovik liat-grozovik liat-grozovik approved these changes

@dgsudharsan dgsudharsan dgsudharsan approved these changes

Assignees
No one assigned
Labels
Included in 202205 Branch Platform: Mellanox Request for 202205 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vivekrnv @mssonicbld @zhenggen-xu @dgsudharsan @liat-grozovik @yxieca