[arp_update]: Resolve failed neighbors on dualtor #11615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
5 tasks
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
prsunny
reviewed
Aug 4, 2022
files/scripts/arp_update
Outdated
| # on dual ToR devices, try to resolve failed neighbor entries since | ||
| # these entries will have tunnel routes installed, preventing normal | ||
| # neighbor resolution | ||
| KERNEL_NEIGHBORS=$(ip -4 neigh show | grep Vlan | cut -d ' ' -f 1,3,6 --output-delimiter=','; \ |
There was a problem hiding this comment.
As discussed offline, let move this section to first loop.
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
prsunny
approved these changes
Aug 4, 2022
7 tasks
yxieca
pushed a commit
that referenced
this pull request
Aug 11, 2022
In arp_update, check for FAILED or INCOMPLETE kernel neighbor entries and manually ping them to try and resolve the neighbor Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
skbarista
pushed a commit
to skbarista/sonic-buildimage
that referenced
this pull request
Aug 17, 2022
In arp_update, check for FAILED or INCOMPLETE kernel neighbor entries and manually ping them to try and resolve the neighbor Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lawrence Lee lawlee@microsoft.com
There is a separate PR to bring this change into the 202012 branch #11641
Why I did it
On dual ToR devices, failed neighbor entries result in tunnel routes being added to the peer switch by orchagent. These tunnel routes prevent the neighbor entries from being resolved if the neighbor ever becomes responsive again.
How I did it
In arp_update, check for FAILED or INCOMPLETE kernel neighbor entries and manually ping them to try and resolve the neighbor
How to verify it
Run sonic-mgmt test dualtor/test_orchagent_active_tor_downstream.py::test_active_tor_remove_neighbor_downstream_active[ipv6] (requires changes in this PR to pass: sonic-net/sonic-mgmt#6071)
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)