[Yang] Update Yang for pfc_enable and pfcwd_sw_enable fields
#11747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yxieca
approved these changes
Aug 16, 2022
yxieca
pushed a commit
that referenced
this pull request
Aug 17, 2022
Why I did it This PR is to update Yang model for pfc_enable and pfcwd_sw_enable fields to support more than 2 queues, like 2,3,4,6. Before this change, the regex "[0-7](,[0-7])?" accepts only no more than 2 queues. How I did it Update the regex pattern for pfc_enable and pfcwd_sw_enable, from "[0-7](,[0-7])?" to "[0-7](,[0-7])* How to verify it The change is verified by UT. The test input is updated to cover the change. collected 3 items tests/test_sonic_yang_models.py .. [ 66%] tests/yang_model_tests/test_yang_model.py .
liushilongbuaa
added a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Aug 19, 2022
This reverts commit 53a2810.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
This PR is to update Yang model for
pfc_enableandpfcwd_sw_enablefields to support more than 2 queues, like2,3,4,6.Before this change, the regex
"[0-7](,[0-7])?"accepts only no more than 2 queues.How I did it
Update the regex pattern for
pfc_enableandpfcwd_sw_enable, from"[0-7](,[0-7])?"to"[0-7](,[0-7])*How to verify it
The change is verified by UT. The test input is updated to cover the change.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Update Yang model for
pfc_enableandpfcwd_sw_enablefields to support more than 2 queues, like2,3,4,6.Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)