Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202205] Add linux perf tool to sonic image #11817

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

Junchao-Mellanox
Copy link
Collaborator

Why I did it

Add linux perf tool to sonic image

How I did it

Use apt install in build_debian.sh

How to verify it

Run build

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@Junchao-Mellanox
Copy link
Collaborator Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Junchao-Mellanox
Copy link
Collaborator Author

Hi @qiluo-msft , could you please suggest a reviewer from MSFT side?

@qiluo-msft
Copy link
Collaborator

Is it only required in a debug image? Seem like occupying several MB disk space.

@Junchao-Mellanox
Copy link
Collaborator Author

Is it only required in a debug image? Seem like occupying several MB disk space.

Hi, we want to put it into regular image so that we can use this tool to debug issues in production environment. I suppose a few MB disk space is fine.

@qiluo-msft qiluo-msft requested review from yxieca and removed request for liuh-80 August 30, 2022 22:26
@yxieca
Copy link
Contributor

yxieca commented Aug 31, 2022

Is it only required in a debug image? Seem like occupying several MB disk space.

Hi, we want to put it into regular image so that we can use this tool to debug issues in production environment. I suppose a few MB disk space is fine.

Why is this change not done against master branch and requesting for back porting? Does master branch have this change already?

@liat-grozovik
Copy link
Collaborator

@Junchao-Mellanox it should be in master as well. Do we have it? If not let's tart with master and then cherry pick. If cannot be cherry picked we will use this one

@Junchao-Mellanox
Copy link
Collaborator Author

sure.

@Junchao-Mellanox
Copy link
Collaborator Author

Created PR for master #11817

@yxieca yxieca merged commit ba020df into sonic-net:202205 Aug 31, 2022
@Junchao-Mellanox Junchao-Mellanox deleted the add-perf branch June 12, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants