Upgrade docker-sonic-mgmt base image from Ubuntu18.04 to 20.04 #11831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wsycqyz Did you run the tests using default python2 or python3 from virtualenv? Wondering if any dependent package is missing from the python3 virtualenv. |
|
BTW, can ansible be upgraded in the python3 virtual env? |
Py3 dependencies will be added in another PR along with packages requested by WAN team. |
It seems that the answer is no. pytest-ansible module cannot support newer Ansible version. |
wangxin
approved these changes
Aug 25, 2022
|
Removed the labels because we only use sonic-mgmt image built from master branch. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
In order to support Python3 migration of docker-sonic-mgmt, the docker base image should be upgrade first.
How I did it
Modify docker build file(docker-sonic-mgmt/Dockerfile.j2):
How to verify it
Randomly select supported testbed, manually run a few tests and all pass:
fib/test_fib.py
vxlan/test_vxlan_decap.py
fdb/test_fdb.py
decap/test_decap.py
pfcwd/test_pfcwd_all_port_storm.py
acl/null_route/test_null_route_helper.py
acl/test_acl.py
vlan/test_vlan.py
platform_tests/test_reboot.py
qos/test_qos_sai.py::TestQosSai::testQosSaiPfcXoffLimit[None-xoff_1]
Which release branch to backport (provide reason below if selected)
Description for the changelog
Update docker-sonic-mgmt/Dockerfile.j2. After upgrade, Py2 is 2.7.18, Py3 is 3.8.10, Ubuntu is 20.04.