Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yang model table DEVICE_NEIGHBOR_METADATA creation #11894

Merged
merged 3 commits into from
Sep 13, 2022
Merged

yang model table DEVICE_NEIGHBOR_METADATA creation #11894

merged 3 commits into from
Sep 13, 2022

Conversation

jcaiMR
Copy link
Contributor

@jcaiMR jcaiMR commented Aug 30, 2022 •
edited
Loading

Why I did it

Add support for DEVICE_NEIGHBOR_METADATA yang model table

How I did it

Create new yang files for DEVICE_NEIGHBOR_METADATA , add UT.

How to verify it

Run UT for sonic-yang-models

Which release branch to backport (provide reason below if selected)

  • 202205

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

fixes #10545

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 30, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@jcaiMR jcaiMR marked this pull request as draft August 30, 2022 10:52
@qiluo-msft qiluo-msft added the YANG YANG model related changes label Aug 30, 2022
@ganglyu
Copy link
Contributor

ganglyu commented Sep 2, 2022

Unit tests for sonic-config-engine failed.

@ganglyu
Copy link
Contributor

ganglyu commented Sep 2, 2022

why do you update submodule for frr?

@jcaiMR
Copy link
Contributor Author

jcaiMR commented Sep 2, 2022

/easycla

@jcaiMR
Copy link
Contributor Author

jcaiMR commented Sep 2, 2022

why do you update submodule for frr?

Thanks for point this out, it's a miss op by commit, I will move it our.

@jcaiMR jcaiMR closed this Sep 2, 2022
@jcaiMR jcaiMR reopened this Sep 2, 2022
@yejianquan
Copy link
Contributor

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yejianquan
Copy link
Contributor

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jcaiMR jcaiMR marked this pull request as ready for review September 2, 2022 14:25
@jcaiMR
Copy link
Contributor Author

jcaiMR commented Sep 5, 2022

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jcaiMR
Copy link
Contributor Author

jcaiMR commented Sep 5, 2022

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jcaiMR jcaiMR merged commit b34d94b into sonic-net:master Sep 13, 2022
@SavchukRomanLv SavchukRomanLv mentioned this pull request Oct 7, 2022
Closed
@jcaiMR jcaiMR mentioned this pull request Oct 21, 2022
Closed
7 tasks
@jcaiMR jcaiMR mentioned this pull request Oct 31, 2022
Merged
@wangxin wangxin mentioned this pull request May 5, 2023
Merged
6 tasks
@liushilongbuaa
Copy link
Contributor

liushilongbuaa commented May 11, 2023 •
edited
Loading

@yxieca , the original repo has some issue. Here is the response from github:

I have been updated that the affected pull request did not run because the forked repository was duplicated on the 29th of March 2023 and the first one was marked as inactive.

The pull request was from the first inactive repository, so the pull request points to a repository ID that doesn't exist, because it somehow was recreated.

As you mentioned you won't experience this issue from other forked repositories, but if you have other PRs from the same repository from before March 29, they might run into the same issue. Otherwise other pull requests from the repository should run as expected.

@liushilongbuaa
Copy link
Contributor

@StormLiangMS , @yxieca , for this PR, auto cherry pick flow didn't work.
If feature is needed please manually cherry pick

yxieca pushed a commit to yxieca/sonic-buildimage that referenced this pull request May 11, 2023
@jcaiMR @yxieca
yang model table DEVICE_NEIGHBOR_METADATA creation (sonic-net#11894)
70d6d9b 
* yang mode support for neighbor metadata

* add description in leaf node

* modify description
@yxieca yxieca mentioned this pull request May 11, 2023
Merged
10 tasks
yxieca added a commit that referenced this pull request May 12, 2023
@yxieca @jcaiMR
yang model table DEVICE_NEIGHBOR_METADATA creation (#11894) (#15026)
1496d1d 
* yang mode support for neighbor metadata

* add description in leaf node

* modify description

Co-authored-by: jcaiMR <111116206+jcaiMR@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganglyu ganglyu ganglyu approved these changes

@dgsudharsan dgsudharsan Awaiting requested review from dgsudharsan

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft qiluo-msft is a code owner

@praveen-li praveen-li Awaiting requested review from praveen-li

Assignees
No one assigned
Labels
Approved for 202211 Branch Cherry Pick Conflict_202211 Included in 202205 Branch Request for 202205 Branch Request for 202211 Branch YANG YANG model related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[yang] Need Yang for DEVICE_NEIGHBOR_METADATA table
7 participants
@jcaiMR @ganglyu @yejianquan @zhangyanzhao @liushilongbuaa @qiluo-msft @yxieca