Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[actions] Add github context env in label action. #11926

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

liushilongbuaa
Copy link
Contributor

@liushilongbuaa liushilongbuaa commented Sep 1, 2022

Why I did it

GITHUB_CONTEXT didn't been passed to label action.
PR approval failed.

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@liushilongbuaa liushilongbuaa marked this pull request as ready for review September 1, 2022 05:59
@@ -23,6 +23,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: approve
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approval step should be in another action, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the same trigger. Maybe we can change the file name from label.yml to label_approve.yml

@liushilongbuaa liushilongbuaa merged commit 030de9f into sonic-net:master Sep 2, 2022
@liushilongbuaa liushilongbuaa deleted the fix-9-1-1 branch October 18, 2022 07:00
StormLiangMS pushed a commit that referenced this pull request Aug 29, 2023
Why I did it
Cherry-Pick #11926 into 202012

Work item tracking
Microsoft ADO (17850717):
How I did it
Create patch file to avoid notify race between io and main pthreads.

How to verify it
PR test, physical DUT for bgp related regression tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants