Use the macsec_enabled flag in platform to enable macsec feature state #11998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
judyjoseph
force-pushed
the
macsec_feature_enable
branch
from
3f0962f to
70ea066
Compare
abdosi
reviewed
Sep 28, 2022
abdosi
reviewed
Sep 28, 2022
|
@anamehra can we add this flag for your platforms ? |
judyjoseph
force-pushed
the
macsec_feature_enable
branch
from
9aa34b6 to
e0705e4
Compare
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
abdosi
approved these changes
Oct 7, 2022
Pterosaur
approved these changes
Oct 11, 2022
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
pushed a commit
that referenced
this pull request
Nov 10, 2022
#11998) * Use the macsec_enabled flag in platform to enable macesc feature state * Add macsec supported metadata in DEVICE_RUNTIME_METADATA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Plan to use the macsec capability flag in the platform - to enable macsec feature which inturn hep hostcfgd to start the macsec dockers
How I did it
Add a new flag "macsec_enabled" in the platform_env.conf in the platform directory - which states if that platform has macsec capability
Add a new API in device_info to get the macsec capability from platform and export to an environment variable MACSEC_SUPPORTED used in hostcfgd.
How to verify it
Verified that the MACSEC_SUPPORTED variable is updated as per the "macsec_enabled" flag set in the platform_env.conf -- and hostcfgd updates the macsec feature state accordingly.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)