04.Version cache - debug framework #12004
Closed
+425
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kalimuthu-Velappan
requested review from
qiluo-msft,
xumia and
lguohan
as code owners
|
This pull request introduces 1 alert when merging 99139ae6c8ae9d61185335036d437e2c6c8e91d5 into 38cc35f - view on LGTM.com new alerts:
|
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@xumia @liushilongbuaa submitter has taken the time to split the original code PR to smaller submissions for review, pls help take a look |
Kalimuthu-Velappan
force-pushed
the
DEBUG_FLAGS
branch
from
99139ae to
483d646
Compare
7 tasks
|
@xumia @liushilongbuaa can you please review the PR? Thanks. |
Kalimuthu-Velappan
force-pushed
the
DEBUG_FLAGS
branch
2 times, most recently
from
a84264c to
e2d7d08
Compare
It defines and passes the necessary version cache environment variables to the caching framework. It adds the utils script for shared cache file access. It also adds the post-cleanup logic for cleaning the unwanted files from the docker/image after the version cache creation.
Added DBGOPT Make variable to enable the cache framework scripts in trace mode. This option takes the part name of the script to enable the particular shell script in trace mode. Multiple shell script names can also be given. Eg: make DBGOPT="image|docker" Added verbose mode to dump the version merge details during build/dry-run mode. Eg: scripts/versions_manager.py freeze -v \ 'dryrun|cmod=docker-swss|cfile=versions-deb|cname=all|stage=sub|stage=add'
Kalimuthu-Velappan
force-pushed
the
DEBUG_FLAGS
branch
from
e2d7d08 to
1b9b275
Compare
xumia
reviewed
Dec 12, 2022
| @@ -221,12 +234,14 @@ SLAVE_TAG = $(shell \ | |||
| (cat $(SLAVE_DIR)/Dockerfile.user \ | |||
| $(SLAVE_DIR)/Dockerfile \ | |||
| $(SLAVE_DIR)/buildinfo/versions/versions-* \ | |||
| .git/HEAD \ | |||
| .git/HEAD 2>/dev/null \ | |||
There was a problem hiding this comment.
Can we remove the .git/HEAD? It has impact on PR check.
|
It is merged as part of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added DBGOPT Make variable to enable the cache framework
scripts in trace mode. This option takes the part name of the script to
enable the particular shell script in trace mode.
Multiple shell script names can also be given.
Added verbose mode to dump the version merge details during
build/dry-run mode.
Eg: scripts/versions_manager.py freeze -v
'dryrun|cmod=docker-swss|cfile=versions-deb|cname=all|stage=sub|stage=add'
Why I did it
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)