[Build] Fix dbus-run-session command not found issue when install dbus-python #12009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xumia
added
Request for 202012 Branch
Request for 202106 Branch
Request for 202111 Branch
StormLiangMS
approved these changes
Sep 8, 2022
| @@ -72,7 +72,8 @@ RUN apt-get install -y net-tools \ | |||
| {%- if ENABLE_ASAN == "y" %} | |||
| libasan5 \ | |||
| {%- endif %} | |||
| libsystemd0 | |||
| libsystemd0 \ | |||
| dbus | |||
There was a problem hiding this comment.
@xumia just one quick question, where to specify the version of dbus for this branch?
There was a problem hiding this comment.
@StormLiangMS , you mean for reproducible build right?
We can specify version in release branches, such as 202012, 202205, not in master branch.
Staphylo
approved these changes
Sep 8, 2022
|
hi @xumia , can you also raise PRs to 202012/202205? |
yxieca
pushed a commit
that referenced
this pull request
Sep 8, 2022
xumia
added a commit
to xumia/sonic-buildimage-1
that referenced
this pull request
Sep 13, 2022
7 tasks
xumia
added a commit
to xumia/sonic-buildimage-1
that referenced
this pull request
Sep 13, 2022
xumia
added a commit
to xumia/sonic-buildimage-1
that referenced
this pull request
Sep 13, 2022
Has already merged in 202205 branch, no affect 202012. |
xumia
added a commit
that referenced
this pull request
Sep 26, 2022
…#12009) (#12054) Why I did it Cherry-pick #12009, and fix code conflict. Fix the dbus-pyhon installation failure when building docker-sonic-vs, caused by the command dbus-run-session not found. The command "dbus-run-session" should be the new dependency introduced in dbus-python 1.3.2, the old version 1.2.18 does not have the issue. How I did it Install the dbus debian package which contains the command dbus-run-session. It is not a blocking issue on release branches. The release branches with reproducible build feature can avoid such issue in official builds and PR builds, it only block the version upgrade (trying to upgrade from 1.2.18 to 1.3.2). How to verify it
xumia
added a commit
that referenced
this pull request
Sep 26, 2022
…#12009) (#12055) Why I did it Cherry-pick #12009, and fix code conflict. Fix the dbus-pyhon installation failure when building docker-sonic-vs, caused by the command dbus-run-session not found. The command "dbus-run-session" should be the new dependency introduced in dbus-python 1.3.2, the old version 1.2.18 does not have the issue. How I did it Install the dbus debian package which contains the command dbus-run-session. It is not a blocking issue on release branches. The release branches with reproducible build feature can avoid such issue in official builds and PR builds, it only block the version upgrade (trying to upgrade from 1.2.18 to 1.3.2).
xumia
added a commit
to xumia/sonic-buildimage-1
that referenced
this pull request
Nov 2, 2022
|
@xumia PR conflicts with 202106 branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Fix the dbus-pyhon installation failure when building docker-sonic-vs, caused by the command dbus-run-session not found.
The command "dbus-run-session" should be the new dependency introduced in dbus-python 1.3.2, the old version 1.2.18 does not have the issue.
How I did it
Install the dbus debian package which contains the command dbus-run-session.
It is not a blocking issue on release branches. The release branches with reproducible build feature can avoid such issue in official builds and PR builds, it only block the version upgrade (trying to upgrade from 1.2.18 to 1.3.2).
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)