Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minigraph] Remove SLB and bgp monitor peers for storage backend #12251

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

neethajohn
Copy link
Contributor

Signed-off-by: Neetha John nejo@microsoft.com

Why I did it

slb and bgp mon peers are not needed for storage backend. These neighbor are present in the minigraph.

How I did it

After minigraph parsing, remove these neighbors if it is a storage backend device

How to verify it

Unit tests
Verified on the device that once these tables are removed, these peers don't show up in "show runningconfig bgp" output

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Signed-off-by: Neetha John <nejo@microsoft.com>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 30, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: neethajohn / name: Neetha John (8a0b440)

Signed-off-by: Neetha John <nejo@microsoft.com>
@neethajohn
Copy link
Contributor Author

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@neethajohn neethajohn merged commit 615f277 into sonic-net:master Oct 7, 2022
@neethajohn neethajohn deleted the bkend_slb_disable branch October 7, 2022 16:37
neethajohn added a commit that referenced this pull request Oct 10, 2022
…kend (#12262)

Why I did it
This is to backport #12251 to 202012

Signed-off-by: Neetha John <nejo@microsoft.com>
yxieca pushed a commit that referenced this pull request Oct 25, 2022
)

Signed-off-by: Neetha John nejo@microsoft.com

Why I did it
slb and bgp mon peers are not needed for storage backend. These neighbor are present in the minigraph.

How I did it
After minigraph parsing, remove these neighbors if it is a storage backend device

How to verify it
Unit tests
Verified on the device that once these tables are removed, these peers don't show up in "show runningconfig bgp" output
neethajohn added a commit to sonic-net/sonic-mgmt that referenced this pull request Nov 30, 2022
Signed-off-by: Neetha John <nejo@microsoft.com>

bgpmon and slb peers were removed for storage backend topology as part of sonic-net/sonic-buildimage#12251 which was causing bgp speaker test to fail on t0-backend topology. Hence skipping this test on backend topo
wangxin pushed a commit to sonic-net/sonic-mgmt that referenced this pull request Dec 7, 2022
Signed-off-by: Neetha John <nejo@microsoft.com>

bgpmon and slb peers were removed for storage backend topology as part of sonic-net/sonic-buildimage#12251 which was causing bgp speaker test to fail on t0-backend topology. Hence skipping this test on backend topo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants