Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[submodule] Advance sonic-py-swsssdk pointer #12559

Conversation

dprital
Copy link
Collaborator

@dprital dprital commented Oct 31, 2022

Signed-off-by: dprital drorp@nvidia.com

Why I did it

Update sonic-py-swsssdk submodule pointer to include the following:

  • 7f008a1 Fix UT test_BlockUseSwsssdk() (#128)
  • e30a1e1 Throw exception when not use swsssdk in UT. (#126)

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Update sonic-py-swsssdk submodule pointer to include the following:
* e30a1e1 Throw exception when not use swsssdk in UT. ([sonic-net#126](sonic-net/sonic-py-swsssdk#126))

Signed-off-by: dprital <drorp@nvidia.com>
@qiluo-msft
Copy link
Collaborator

@liuh-80 Could you help check the build failure? Related to swsssdk deprecation.

@liuh-80
Copy link
Contributor

liuh-80 commented Nov 1, 2022

The change in swsssdk been tested with this PR: https://github.com/sonic-net/sonic-buildimage/pull/12036/files#diff-fe7afb5c9c916e521401d3fcfb4277d5071798c3baf83baf11d6071742823584

The issue happen because currently sonic-build-image using python2 to build image, I will check if it's a build pipeline issue.

@liuh-80
Copy link
Contributor

liuh-80 commented Nov 1, 2022

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80
Copy link
Contributor

liuh-80 commented Nov 10, 2022

@dprital , the UT failed with python2 issue fixed with this PR: sonic-net/sonic-py-swsssdk#128

@dprital
Copy link
Collaborator Author

dprital commented Nov 10, 2022

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@dprital dprital marked this pull request as ready for review November 10, 2022 09:33
@liat-grozovik
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik liat-grozovik merged commit fd078af into sonic-net:master Nov 14, 2022
@dprital dprital deleted the sub_module_master_update_sonic-py-swsssdk branch November 14, 2022 22:50
davidpil2002 pushed a commit to davidpil2002/sonic-buildimage that referenced this pull request Nov 15, 2022
Update sonic-py-swsssdk submodule pointer to include the following:

7f008a1 Fix UT test_BlockUseSwsssdk() (sonic-net#128)
e30a1e1 Throw exception when not use swsssdk in UT. (sonic-net#126)

Signed-off-by: dprital <drorp@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants