-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish additional events #12563
Publish additional events #12563
Conversation
This pull request introduces 1 alert when merging 1c69b25 into 2626573 - view on LGTM.com new alerts:
|
@@ -55,6 +57,11 @@ def __init__(self): | |||
|
|||
self.load_critical_process_cache() | |||
|
|||
self.events_handle = events_init_publisher(EVENTS_PUBLISHER_SOURCE) | |||
|
|||
def __del__(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
__del__
is hacky. Suggest follow https://stackoverflow.com/a/6104568/2514803 for unmanaged resource. #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer use del, moved deinit to the end of check() method which is the main driver of the script, used by manager.py
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
@zbud-msft I am getting the following traceback. Can you please investigate? Program 'container_memory_telemetry' Here is a full trace |
Fixed as part of #12797 |
Why I did it
Add event_publish code or regex for rsyslog plugin for additional events
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)