Allow TSA on ibgp sessions between linecards on packet chassis #12589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjchadaga
added
Chassis 🤖
arlakshm
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
On packet chassis, ibgp sessions between ASICs of different linecards are also considered internal. Currently, these internal ibgp sessions are skipped while the device is isolated with TSA. As a result, when TSA is done on one linecard, bgp routes are still advertised to other linecards, hence drawing traffic (if the other linecard is not isolated).
How I did it
For packet chassis, allow TSA to withdraw routes from internal ibgp sessions as well. As a result of this change, the ibgp sessions between ASICs on the same linecard are also isolated when TSA is done.
This change does not impact the current behavior on multi-asic pizza boxes, where the ibgp sessions between the asics are not isolated on TSA.
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)