Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chassis] [Arista] correct platform.json for sup and LC6 names #12627

Merged
merged 16 commits into from
Nov 8, 2022
Merged

[Chassis] [Arista] correct platform.json for sup and LC6 names #12627

merged 16 commits into from
Nov 8, 2022

Conversation

wenyiz2021
Copy link
Contributor

@wenyiz2021 wenyiz2021 commented Nov 7, 2022

for partial issues in #12590

  1. Correct Arista chassis sup name to match with dut:
admin@str2-7804-sup-1:~$ show platform sum
...
Model Number: DCS-7800-SUP1A
  1. add separate platform.json for LC6, which has different name bc of supporting macsec, all other infos are the same as the other 2 LC2:
admin@str2-7804-lc6-1:~$ show platform sum
Platform: x86_64-arista_7800r3_48cqm2_lc
HwSKU: Arista-7800R3-48CQM2-C48
...

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@wenyiz2021 wenyiz2021 requested review from Staphylo, arlakshm and rlhui and removed request for rlhui November 7, 2022 23:26
Signed-off-by: Wenyi Zhang <wenyizhang@microsoft.com>
Copy link
Collaborator

@Staphylo Staphylo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this.
I will need to make some more modification to these files to make testing happy.

@wenyiz2021 wenyiz2021 self-assigned this Nov 8, 2022
@wenyiz2021 wenyiz2021 changed the title [Chassis] [Arista] correct platform.json for sup and LC6 [Chassis] [Arista] correct platform.json for sup and LC6 names Nov 8, 2022
@wenyiz2021
Copy link
Contributor Author

wenyiz2021 commented Nov 8, 2022

Thanks for doing this. I will need to make some more modification to these files to make testing happy.

@Staphylo not sure how much is the platform.json covered in your regression, just a kindly reminder that this won't be the final version, as psus, thermal sections also needs changes, you may want to wait after we both finalized the file.

@wenyiz2021 wenyiz2021 merged commit f581a77 into sonic-net:master Nov 8, 2022
@wenyiz2021 wenyiz2021 deleted the arista_platform_json branch November 8, 2022 20:56
yxieca pushed a commit that referenced this pull request Nov 10, 2022
add platform.json separately for LC6 that has different name, bc of supporting macsec
Signed-off-by: Wenyi Zhang <wenyizhang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants