Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Update SLAVE_BASE_TAG and DPKG cache if Debian mirrors were changed #12702

Merged
merged 2 commits into from
Nov 15, 2022

Conversation

kv-y
Copy link
Contributor

@kv-y kv-y commented Nov 14, 2022

Why I did it

After #12557 sources.lists are generated.
So we need to recalculate SLAVE_BASE_TAG if mirrors were changed.
Also we need to rebuild DPKG cache in this case.

How I did it

  1. Use generated sources.list for SLAVE_BASE_TAG
  2. Add MIRROR_URLS and MIRROR_SECURITY_URLS to SONIC_COMMON_FLAGS_LIST

Signed-off-by: Konstantin Vasin k.vasin@yadro.com

@kv-y
Copy link
Contributor Author

kv-y commented Nov 14, 2022

@xumia FYI
Before #12557 debian mirrors were in sonic-slave-xxx/Dockerfile.j2.
Also sources.list in dockers/docker-base-xxx were in deps list for docker-base-xxx.

Now if I change MIRROR_URLS and/or MIRROR_SECURITY_URLS then sonic-slave-xxx images and docker-base (from DPKG cache) doesn't update.
I'm not sure about solution based on SONIC_COMMON_FLAGS_LIST, but I can't use files (sources.list) from docker-base-xxx directory because they are generated after dependency check.

@xumia
Copy link
Collaborator

xumia commented Nov 15, 2022

@kv-y , thanks for fixing it.

@xumia xumia merged commit c63e9fe into sonic-net:master Nov 15, 2022
davidpil2002 pushed a commit to davidpil2002/sonic-buildimage that referenced this pull request Nov 15, 2022
…hanged (sonic-net#12702)

Why I did it
After sonic-net#12557 sources.lists are generated.
So we need to recalculate SLAVE_BASE_TAG if mirrors were changed.
Also we need to rebuild DPKG cache in this case.

How I did it
Use generated sources.list for SLAVE_BASE_TAG
Add MIRROR_URLS and MIRROR_SECURITY_URLS to SONIC_COMMON_FLAGS_LIST
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants